Merge pull request #62 from MultiSimOLab/cofactor

Author: jmartfrut

benchmark/TensorAlgebraBenchmarks/TensorAlgebraBenchmarks.jl

@@ -42,5 +42,10 @@ function _δδ_λ_2D(λ::Float64)
     λ)
 end
 
+A = TensorValue(1.:9...)
+A = A + A' + I3
+
 SUITE["Tensor algebra"]["δδ_μ_2d"] = @benchmarkable δᵢₖδⱼₗ2D + δᵢₗδⱼₖ2D
 SUITE["Tensor algebra"]["δδ_λ_2d"] = @benchmarkable 1.0 * δᵢⱼδₖₗ2D
+SUITE["Tensor algebra"]["Cofactor"] = cof(A)
+SUITE["Tensor algebra"]["Det(A)Inv(A')"] = det(A)*inv(A')

src/TensorAlgebra/Functions.jl

@@ -17,7 +17,7 @@ end
 Calculate the cofactor of a matrix.
 """
 function cof(A::TensorValue)
-  return det(A)*inv(A')
+  0.5A×A
 end
 
 

test/TestTensorAlgebra/TensorAlgebra.jl renamed to test/TestTensorAlgebra/TensorAlgebraTests.jl

@@ -104,5 +104,13 @@ end
 @testset "sqrt" begin
   A = TensorValue(1.:9...)
   A = A'*A + I3
-  @test isapprox(sqrt(A), TensorValue(sqrt(get_array(A))), rtol=1e-14)
+  sqrtA = TensorValue(sqrt(get_array(A)))
+  @test isapprox(sqrt(A), sqrtA, rtol=1e-14)
+end
+
+
+@testset "cofactor" begin
+  A = TensorValue(1.:9...) + I3
+  cofA = det(A) * inv(A')
+  @test isapprox(cof(A), cofA)
 end

test/TestTensorAlgebra/runtests.jl

@@ -1,7 +1,11 @@
+using HyperFEM
+using Gridap
+using Test
+
 @testset "TensorAlgebra" begin
 
-    @time begin
-        include("TensorAlgebra.jl")
-    end
+  @time begin
+    include("TensorAlgebraTests.jl")
+  end
 
-end
+end