MDI240 | remove eml_file_path column

Author: emidiocruciani

docker/mysql/migrations/001_create_emails_table.sql

@@ -6,7 +6,6 @@ CREATE TABLE IF NOT EXISTS emails (
         'CALLING-SENT-CALLBACK','CALLING-FAILED-CALLBACK',
         'SENT-ACKNOWLEDGED','FAILED-ACKNOWLEDGED'
     ) NOT NULL,
-    eml_file_path VARCHAR(500),
     payload_file_path VARCHAR(500),
     reason TEXT,
     version INT NOT NULL DEFAULT 1,

docs/database.md

@@ -5,7 +5,6 @@
 type Email struct {
     Id              string
     Status          string
-    EmlFilePath     string // Campo mantenuto per compatibilità, non usato
     PayloadFilePath string
     UpdatedAt       string
     Reason          string
@@ -27,7 +26,6 @@ CREATE TABLE IF NOT EXISTS emails (
         'CALLING-SENT-CALLBACK','CALLING-FAILED-CALLBACK',
         'SENT-ACKNOWLEDGED','FAILED-ACKNOWLEDGED'
     ) NOT NULL,
-    eml_file_path VARCHAR(500),
     payload_file_path VARCHAR(500),
     reason TEXT,
     version INT NOT NULL DEFAULT 1,
@@ -75,7 +73,7 @@ Le query di lettura utilizzano `FOR UPDATE SKIP LOCKED` per:
 - Migliorare il throughput in scenari con più processori concorrenti
 
 ```sql
-SELECT id, status, eml_file_path, payload_file_path, reason, version, updated_at
+SELECT id, status, payload_file_path, reason, version, updated_at
 FROM emails
 WHERE status = ?
 ORDER BY updated_at ASC

internal/outbox/outbox.go

@@ -44,7 +44,6 @@ var retryableErrNos = map[uint16]bool{
 type Email struct {
 	Id              string
 	Status          string
-	EmlFilePath     string
 	PayloadFilePath string
 	UpdatedAt       string
 	Reason          string
@@ -133,7 +132,7 @@ func (o *Outbox) Query(ctx context.Context, status string, limit int) ([]Email,
 	// - Rows currently locked by other transactions are skipped
 	// - Reduces contention when multiple workers poll simultaneously
 	query := `
-		SELECT id, status, eml_file_path, payload_file_path, reason, version, updated_at
+		SELECT id, status, payload_file_path, reason, version, updated_at
 		FROM emails
 		WHERE status = ?
 		ORDER BY updated_at ASC
@@ -150,13 +149,12 @@ func (o *Outbox) Query(ctx context.Context, status string, limit int) ([]Email,
 	var emails []Email
 	for rows.Next() {
 		var e Email
-		var emlFilePath, payloadFilePath, reason sql.NullString
+		var payloadFilePath, reason sql.NullString
 		var updatedAt time.Time
 
 		err := rows.Scan(
 			&e.Id,
 			&e.Status,
-			&emlFilePath,
 			&payloadFilePath,
 			&reason,
 			&e.Version,
@@ -166,7 +164,6 @@ func (o *Outbox) Query(ctx context.Context, status string, limit int) ([]Email,
 			return []Email{}, err
 		}
 
-		e.EmlFilePath = emlFilePath.String
 		e.PayloadFilePath = payloadFilePath.String
 		e.Reason = reason.String
 		e.UpdatedAt = updatedAt.Format(time.RFC3339)
@@ -288,13 +285,13 @@ func (o *Outbox) Requeue(ctx context.Context, id string) error {
 	return err
 }
 
-// Ready updates the email to READY status with the eml file path.
+// Ready updates the email to READY status.
 // Expected from status is INTAKING.
 // The operation is executed within a transaction with retry logic for transient errors.
-func (o *Outbox) Ready(ctx context.Context, id string, emlFilePath string) error {
+func (o *Outbox) Ready(ctx context.Context, id string) error {
 	updateQuery := `
 		UPDATE emails
-		SET status = ?, eml_file_path = ?, version = version + 1
+		SET status = ?, version = version + 1
 		WHERE id = ? AND status = ?
 	`
 	historyQuery := `
@@ -305,7 +302,7 @@ func (o *Outbox) Ready(ctx context.Context, id string, emlFilePath string) error
 	var err error
 	for attempt := range maxAttempts {
 		err = o.executeInTransaction(ctx, func(tx *sql.Tx) error {
-			result, execErr := tx.ExecContext(ctx, updateQuery, StatusReady, emlFilePath, id, StatusIntaking)
+			result, execErr := tx.ExecContext(ctx, updateQuery, StatusReady, id, StatusIntaking)
 			if execErr != nil {
 				return execErr
 			}

internal/outbox/outbox_component_test.go

@@ -114,8 +114,8 @@ func TestMySQLOutboxReadyWorkflow(t *testing.T) {
 	require.NoError(t, err)
 	fixtures = append(fixtures, id)
 
-	// update to READY without eml file path
-	err = sut.Ready(context.TODO(), id, "", nil)
+	// update to READY
+	err = sut.Ready(context.TODO(), id)
 	require.NoError(t, err)
 
 	// verify status changed to READY
@@ -124,10 +124,9 @@ func TestMySQLOutboxReadyWorkflow(t *testing.T) {
 	require.Len(t, res, 1)
 	assert.Equal(t, id, res[0].Id)
 	assert.Equal(t, StatusReady, res[0].Status)
-	assert.Empty(t, res[0].EmlFilePath)
 
 	// trying to call Ready again should fail (status is now READY, not INTAKING)
-	err = sut.Ready(context.TODO(), id, "", nil)
+	err = sut.Ready(context.TODO(), id)
 	assert.Error(t, err)
 	assert.ErrorIs(t, err, ErrLockNotAcquired)
 }
@@ -194,7 +193,7 @@ func TestMySQLOutboxStateTransitions(t *testing.T) {
 	assert.Equal(t, StatusIntaking, status)
 
 	// INTAKING -> READY (using Ready method)
-	err = sut.Ready(context.TODO(), id, "", nil)
+	err = sut.Ready(context.TODO(), id)
 	require.NoError(t, err)
 
 	status, err = facade.GetEmailStatus(context.TODO(), id)

internal/outbox/outbox_test.go

@@ -22,11 +22,11 @@ func TestQuery_WhenDatabaseHasRecords_ShouldReturnEmails(t *testing.T) {
 
 	now := time.Now()
 
-	rows := sqlmock.NewRows([]string{"id", "status", "eml_file_path", "payload_file_path", "reason", "version", "updated_at"}).
-		AddRow("test-id-1", "READY", "", "/path/to/payload", "", 1, now).
-		AddRow("test-id-2", "READY", "", "/path/to/payload2", "some reason", 2, now)
+	rows := sqlmock.NewRows([]string{"id", "status", "payload_file_path", "reason", "version", "updated_at"}).
+		AddRow("test-id-1", "READY", "/path/to/payload", "", 1, now).
+		AddRow("test-id-2", "READY", "/path/to/payload2", "some reason", 2, now)
 
-	mock.ExpectQuery("SELECT id, status, eml_file_path, payload_file_path, reason, version, updated_at FROM emails").
+	mock.ExpectQuery("SELECT id, status, payload_file_path, reason, version, updated_at FROM emails").
 		WithArgs("READY", 25).
 		WillReturnRows(rows)
 
@@ -38,7 +38,6 @@ func TestQuery_WhenDatabaseHasRecords_ShouldReturnEmails(t *testing.T) {
 	require.Len(t, emails, 2)
 	assert.Equal(t, "test-id-1", emails[0].Id)
 	assert.Equal(t, "READY", emails[0].Status)
-	assert.Equal(t, "", emails[0].EmlFilePath)
 	assert.Equal(t, "test-id-2", emails[1].Id)
 
 	assert.NoError(t, mock.ExpectationsWereMet())
@@ -70,7 +69,7 @@ func TestQuery_WhenDatabaseHasNoRecords_ShouldReturnEmptySlice(t *testing.T) {
 	require.NoError(t, err)
 	defer db.Close()
 
-	rows := sqlmock.NewRows([]string{"id", "status", "eml_file_path", "payload_file_path", "reason", "version", "updated_at"})
+	rows := sqlmock.NewRows([]string{"id", "status", "payload_file_path", "reason", "version", "updated_at"})
 
 	mock.ExpectQuery("SELECT").
 		WithArgs("READY", 10).
@@ -172,7 +171,7 @@ func TestReady_WhenUpdateSucceeds_ShouldReturnNoError(t *testing.T) {
 
 	sut := NewOutboxWithDB(db)
 
-	err = sut.Ready(context.TODO(), "test-id", "", nil)
+	err = sut.Ready(context.TODO(), "test-id")
 
 	assert.NoError(t, err)
 	assert.NoError(t, mock.ExpectationsWereMet())
@@ -193,7 +192,7 @@ func TestReady_WhenNoRowsAffected_ShouldReturnLockError(t *testing.T) {
 
 	sut := NewOutboxWithDB(db)
 
-	err = sut.Ready(context.TODO(), "test-id", "", nil)
+	err = sut.Ready(context.TODO(), "test-id")
 
 	assert.Error(t, err)
 	assert.ErrorIs(t, err, ErrLockNotAcquired)

internal/pipeline/intake.go

@@ -49,7 +49,7 @@ func (p *IntakePipeline) Process(ctx context.Context) {
 				return
 			}
 
-			if err := p.outbox.Ready(context.Background(), email.Id, ""); err != nil {
+			if err := p.outbox.Ready(context.Background(), email.Id); err != nil {
 				subLogger.Error(fmt.Sprintf("failed to update status to READY: %v", err))
 				p.handle(context.Background(), subLogger, email.Id, outbox.StatusInvalid, err.Error())
 			} else {

internal/pipeline/interface.go

@@ -8,6 +8,6 @@ import (
 type outboxService interface {
 	Query(ctx context.Context, status string, limit int) ([]outbox.Email, error)
 	Update(ctx context.Context, id string, status string, errorReason string) error
-	Ready(ctx context.Context, id string, emlFilePath string) error
+	Ready(ctx context.Context, id string) error
 	Requeue(ctx context.Context, id string) error
 }

internal/testutils/mocks/outbox.go

@@ -87,7 +87,7 @@ func (m *OutboxMock) Update(ctx context.Context, id string, status string, error
 	return nil
 }
 
-func (m *OutboxMock) Ready(ctx context.Context, id string, emlFilePath string) error {
+func (m *OutboxMock) Ready(ctx context.Context, id string) error {
 	m.lastMethod = "ready"
 	m.updateMethodCall++
 	if m.updateMethodCall == m.updateMethodFailsCall {