Skip to content

Commit 1a25afa

Browse files
committed
📝 some notes and comments
- also correcting one typo in comment
1 parent 177163d commit 1a25afa

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/vuegen/quarto_reportview.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -559,6 +559,7 @@ def _generate_plot_content(self, plot) -> List[str]:
559559

560560
# Define plot path
561561
if self.is_report_static:
562+
# ? should that be in the output folder
562563
static_plot_path = (
563564
Path(self.static_dir) / f"{plot.title.replace(' ', '_')}.png"
564565
).absolute()
@@ -592,7 +593,7 @@ def _generate_plot_content(self, plot) -> List[str]:
592593
else:
593594
plot_content.append("""fig_altair\n```\n""")
594595
elif plot.plot_type == r.PlotType.INTERACTIVE_NETWORK:
595-
networkx_graph = plot.read_network()
596+
networkx_graph = plot.read_network() # ? what does this do?
596597
if isinstance(networkx_graph, tuple):
597598
# If network_data is a tuple, separate the network and html file path
598599
networkx_graph, html_plot_file = networkx_graph
@@ -602,7 +603,7 @@ def _generate_plot_content(self, plot) -> List[str]:
602603
networkx_graph, html_plot_file
603604
)
604605

605-
# Add number of nodes and edges to the plor conetnt
606+
# Add number of nodes and edges to the plot content
606607
num_nodes = networkx_graph.number_of_nodes()
607608
num_edges = networkx_graph.number_of_edges()
608609
plot_content.append(f"**Number of nodes:** {num_nodes}\n")

src/vuegen/report_generator.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ def get_report(
126126
quarto_checks=quarto_checks,
127127
static_dir=static_files_dir,
128128
)
129+
# ToDo: output_dir should be passed then in init of QuartoReportView
129130
quarto_report.generate_report(output_dir=report_dir)
130131
quarto_report.run_report(output_dir=report_dir)
131132
# ? Could be also the path to the report file for quarto based reports

0 commit comments

Comments
 (0)