Skip to content

Commit b2b86aa

Browse files
committed
🐛 example data not in normal writable file path for bundled app, put config to output folder?
- could be an option (to discuss) - config file is where output is, not where report - could be otherwise an option to be specified
1 parent 6bea275 commit b2b86aa

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.github/workflows/cdci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,8 @@ jobs:
157157
- name: Build executable
158158
run: |
159159
cd gui
160-
pyinstaller -n vuegen_gui -D -w --collect-all pyvis --collect-all streamlit --collect-all st_aggrid --collect-all customtkinter --collect-all quarto_cli --collect-all plotly --collect-all _plotly_utils --collect-all traitlets --collect-all referencing --collect-all rpds --collect-all tenacity --collect-all pyvis --collect-all pandas --collect-all numpy --collect-all matplotlib --collect-all openpyxl --collect-all xlrd --collect-all nbformat --collect-all nbclient --collect-all altair --collect-all itables --collect-all kaleido --collect-all pyarrow --collect-all dataframe_image --collect-all narwhals --collect-all PIL --add-data ../docs/example_data/Basic_example_vuegen_demo_notebook:example_data/Basic_example_vuegen_demo_notebook app.py
161-
# -w -F
160+
pyinstaller -n vuegen_gui -F -w --collect-all pyvis --collect-all streamlit --collect-all st_aggrid --collect-all customtkinter --collect-all quarto_cli --collect-all plotly --collect-all _plotly_utils --collect-all traitlets --collect-all referencing --collect-all rpds --collect-all tenacity --collect-all pyvis --collect-all pandas --collect-all numpy --collect-all matplotlib --collect-all openpyxl --collect-all xlrd --collect-all nbformat --collect-all nbclient --collect-all altair --collect-all itables --collect-all kaleido --collect-all pyarrow --collect-all dataframe_image --collect-all narwhals --collect-all PIL --add-data ../docs/example_data/Basic_example_vuegen_demo_notebook:example_data/Basic_example_vuegen_demo_notebook app.py
161+
# -w -D
162162
# --collect-all vl_convert --collect-all yaml --collect-all strenum --collect-all jinja2 --collect-all fastjsonschema --collect-all jsonschema --collect-all jsonschema_specifications
163163
# replace by spec file once done...
164164
- name: Upload executable

src/vuegen/report_generator.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ def get_report(
5656
if dir_path:
5757
# Generate configuration from the provided directory
5858
yaml_data, base_folder_path = config_manager.create_yamlconfig_fromdir(dir_path)
59-
config_path = write_yaml_config(yaml_data, base_folder_path)
59+
config_path = write_yaml_config(yaml_data, output_dir)
60+
logger.info("Configuration file generated at %s", config_path)
6061

6162
# Load the YAML configuration file with the report metadata
6263
report_config = load_yaml_config(config_path)

src/vuegen/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ def write_yaml_config(yaml_data: dict, directory_path: Path) -> Path:
514514
raise FileNotFoundError(f"The directory {directory_path} does not exist.")
515515

516516
# Now write the YAML file
517-
with open(output_yaml, "w") as yaml_file:
517+
with open(output_yaml, "w", encoding="utf-8") as yaml_file:
518518
yaml.dump(yaml_data, yaml_file, default_flow_style=False, sort_keys=False)
519519

520520
# Return the path to the written file

0 commit comments

Comments
 (0)