📝 To discuss

enryH · enryH · commit c21413edf1b8 · 2025-05-07T10:07:32.000+02:00
diff --git a/src/vuegen/streamlit_reportview.py b/src/vuegen/streamlit_reportview.py
@@ -642,7 +642,8 @@ def _generate_dataframe_content(self, dataframe) -> List[str]:
                 self.report.logger.error(
                     f"Unsupported file extension: {file_extension}. Supported extensions are: {', '.join(fmt.value for fmt in r.DataFrameFormat)}."
                 )
-                # ? Does this skip the execution step?
+                # return []  # Skip execution if unsupported file extension
+                # Should it not return here? Can we even call the method with an unsupported file extension?
 
             if file_extension in [
                 r.DataFrameFormat.XLS.value_with_dot,

Original file line number	Diff line number	Diff line change
`@@ -642,7 +642,8 @@ def _generate_dataframe_content(self, dataframe) -> List[str]:`
`642`	`642`	`self.report.logger.error(`
`643`	`643`	`f"Unsupported file extension: {file_extension}. Supported extensions are: {', '.join(fmt.value for fmt in r.DataFrameFormat)}."`
`644`	`644`	`)`
`645`		`- # ? Does this skip the execution step?`
	`645`	`+ # return [] # Skip execution if unsupported file extension`
	`646`	`+ # Should it not return here? Can we even call the method with an unsupported file extension?`
`646`	`647`
`647`	`648`	`if file_extension in [`
`648`	`649`	`r.DataFrameFormat.XLS.value_with_dot,`