Skip to content

Commit fd46857

Browse files
committed
🎨 no time zone in log file name, use onefile for windows
- time zone names on windows are too long - onefile on Windows should lead to only one exe - see if option leads to okay option for .app on MAC
1 parent 4a191d8 commit fd46857

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/cdci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ jobs:
155155
- name: Build executable
156156
run: |
157157
cd gui
158-
pyinstaller -n vuegen_gui --windowed --collect-all pyvis --collect-all streamlit --collect-all st_aggrid --collect-all customtkinter --collect-all quarto_cli --collect-all plotly --collect-all _plotly_utils --collect-all traitlets --collect-all referencing --collect-all rpds --collect-all tenacity --collect-all pyvis --collect-all pandas --collect-all numpy --collect-all matplotlib --collect-all openpyxl --collect-all xlrd --collect-all nbformat --collect-all nbclient --collect-all altair --collect-all itables --collect-all kaleido --collect-all pyarrow --collect-all dataframe_image --collect-all narwhals --collect-all PIL --collect-all vl_convert --add-data ../docs/example_data/Basic_example_vuegen_demo_notebook:example_data/Basic_example_vuegen_demo_notebook --add-data ../docs/images/vuegen_logo.png:. app.py
158+
pyinstaller -n vuegen_gui --onefile --windowed --collect-all pyvis --collect-all streamlit --collect-all st_aggrid --collect-all customtkinter --collect-all quarto_cli --collect-all plotly --collect-all _plotly_utils --collect-all traitlets --collect-all referencing --collect-all rpds --collect-all tenacity --collect-all pyvis --collect-all pandas --collect-all numpy --collect-all matplotlib --collect-all openpyxl --collect-all xlrd --collect-all nbformat --collect-all nbclient --collect-all altair --collect-all itables --collect-all kaleido --collect-all pyarrow --collect-all dataframe_image --collect-all narwhals --collect-all PIL --collect-all vl_convert --add-data ../docs/example_data/Basic_example_vuegen_demo_notebook:example_data/Basic_example_vuegen_demo_notebook --add-data ../docs/images/vuegen_logo.png:. app.py
159159
# --windowed only for mac, see:
160160
# https://pyinstaller.org/en/stable/usage.html#building-macos-app-bundles
161161
# 'Under macOS, PyInstaller always builds a UNIX executable in dist.'

src/vuegen/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ def generate_log_filename(folder: str = "logs", suffix: str = "") -> str:
642642
except OSError as e:
643643
raise OSError(f"Error creating directory '{folder}': {e}")
644644
# MAIN FUNCTION
645-
log_filename = get_time(incl_timezone=True) + "_" + suffix + ".log"
645+
log_filename = get_time(incl_timezone=False) + "_" + suffix + ".log"
646646
log_filepath = os.path.join(folder, log_filename)
647647

648648
return log_filepath

0 commit comments

Comments
 (0)