fix: improve webhook setup robustness and add parseGitHubSlug tests

- PR Review modal now always shows result screen (fallback message if
  server returns no setup info), ensuring consistent UX
- Extract parseGitHubSlug as a testable pure function with 8 unit tests
  covering SSH, HTTPS, dots in names, non-GitHub remotes, etc.
- Fix regex to allow dots in repo names (e.g. my_repo.name)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: alari76

server/workflow-routes.test.ts

@@ -0,0 +1,37 @@
+/** Tests for parseGitHubSlug — verifies GitHub slug extraction from various remote URL formats. */
+import { describe, it, expect } from 'vitest'
+import { parseGitHubSlug } from './workflow-routes.js'
+
+describe('parseGitHubSlug', () => {
+  it('parses HTTPS URL with .git suffix', () => {
+    expect(parseGitHubSlug('https://github.com/Multiplier-Labs/codekin.git')).toBe('Multiplier-Labs/codekin')
+  })
+
+  it('parses HTTPS URL without .git suffix', () => {
+    expect(parseGitHubSlug('https://github.com/owner/repo')).toBe('owner/repo')
+  })
+
+  it('parses SSH URL', () => {
+    expect(parseGitHubSlug('git@github.com:owner/repo.git')).toBe('owner/repo')
+  })
+
+  it('parses SSH URL without .git suffix', () => {
+    expect(parseGitHubSlug('git@github.com:owner/repo')).toBe('owner/repo')
+  })
+
+  it('handles trailing whitespace/newline', () => {
+    expect(parseGitHubSlug('git@github.com:owner/repo.git\n')).toBe('owner/repo')
+  })
+
+  it('returns null for non-GitHub remotes', () => {
+    expect(parseGitHubSlug('https://gitlab.com/owner/repo.git')).toBeNull()
+  })
+
+  it('returns null for empty string', () => {
+    expect(parseGitHubSlug('')).toBeNull()
+  })
+
+  it('handles repos with hyphens, underscores, and dots', () => {
+    expect(parseGitHubSlug('git@github.com:my-org/my_repo.name.git')).toBe('my-org/my_repo.name')
+  })
+})

server/workflow-routes.ts

@@ -31,17 +31,24 @@ import { loadWebhookConfig, generateWebhookSecret, saveWebhookConfig } from './w
 
 const execFileAsync = promisify(execFile)
 
+/**
+ * Parse a GitHub `owner/repo` slug from a git remote URL.
+ * Supports SSH (git@github.com:owner/repo.git) and HTTPS (https://github.com/owner/repo.git).
+ * Returns null for non-GitHub remotes.
+ */
+export function parseGitHubSlug(remoteUrl: string): string | null {
+  const match = remoteUrl.trim().match(/github\.com[:/]([^/]+\/[^/]+?)(?:\.git)?$/)
+  return match?.[1] ?? null
+}
+
 /**
  * Derive the GitHub `owner/repo` slug from a local repo path
  * by parsing the git remote origin URL.
  */
 async function getGitHubSlug(repoPath: string): Promise<string | null> {
   try {
     const { stdout } = await execFileAsync('git', ['-C', repoPath, 'remote', 'get-url', 'origin'], { timeout: 5000 })
-    const url = stdout.trim()
-    // Match SSH (git@github.com:owner/repo.git) or HTTPS (https://github.com/owner/repo.git)
-    const match = url.match(/github\.com[:/]([^/]+\/[^/.]+?)(?:\.git)?$/)
-    return match?.[1] ?? null
+    return parseGitHubSlug(stdout)
   } catch {
     return null
   }

src/components/AddWorkflowModal.tsx

@@ -467,8 +467,11 @@ export function AddWorkflowModal({ token, onClose, onAdd }: Props) {
         model: form.model || undefined,
         provider: form.provider !== 'claude' ? form.provider : undefined,
       }, webhookUrl)
-      if (isPrReview && setupResult) {
-        setWebhookResult(setupResult)
+      if (isPrReview) {
+        setWebhookResult(setupResult ?? {
+          status: 'failed',
+          message: 'No webhook setup information returned. Please configure the GitHub webhook manually in Settings.',
+        })
       } else {
         onClose()
       }