Skip to content

Commit 00944ed

Browse files
committed
Always fire onChange for node even if old and new values may be equal
1 parent 5f9b0af commit 00944ed

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/main/java/org/mvplugins/multiverse/core/config/handle/BaseConfigurationHandle.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,8 @@ public <T> Try<Void> set(@NotNull CommandSender sender, @NotNull ValueNode<T> no
179179
return node.validate(value).map(ignore -> {
180180
T oldValue = get(node);
181181
nodeValueMap.put(node, value);
182-
if (!Objects.equals(oldValue, value)) {
183-
node.onLoadAndChange(sender, oldValue, value);
184-
node.onChange(sender, oldValue, value);
185-
}
182+
node.onLoadAndChange(sender, oldValue, value);
183+
node.onChange(sender, oldValue, value);
186184
return null;
187185
});
188186
}

src/main/java/org/mvplugins/multiverse/core/world/WorldConfigNodes.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ NodeGroup getNodes() {
6161

6262
private <T> ConfigNode<T> node(ConfigNode.Builder<T, ?> nodeBuilder) {
6363
nodeBuilder.onChange((oldValue, newValue) -> {
64+
if (Objects.equals(oldValue, newValue)) return;
6465
if (world == null) return;
6566
MVWorldPropertyChangedEvent<?> mvWorldPropertyChangeEvent = new MVWorldPropertyChangedEvent<>(
6667
world,

0 commit comments

Comments
 (0)