Merge branch 'main' into v5.4

Author: benwoo1110

src/main/java/org/mvplugins/multiverse/core/command/MVCommandCompletions.java

@@ -279,19 +279,16 @@ private Collection<String> suggestMVWorlds(BukkitCommandCompletionContext contex
             case "both" -> {
                 return worldManager.getWorlds().stream()
                         .map(MultiverseWorld::getTabCompleteName)
-                        .map(StringFormatter::quoteMultiWordString)
                         .toList();
             }
             case "loaded" -> {
                 return worldManager.getLoadedWorlds().stream()
                         .map(MultiverseWorld::getTabCompleteName)
-                        .map(StringFormatter::quoteMultiWordString)
                         .toList();
             }
             case "unloaded" -> {
                 return worldManager.getUnloadedWorlds().stream()
                         .map(MultiverseWorld::getTabCompleteName)
-                        .map(StringFormatter::quoteMultiWordString)
                         .toList();
             }
             case "potential" -> {

src/main/java/org/mvplugins/multiverse/core/command/MVRootCommand.java

@@ -22,6 +22,9 @@ public BaseCommand execute(CommandIssuer sender, String commandLabel, String[] a
     @Override
     public List<String> getTabCompletions(CommandIssuer sender, String alias, String[] args, boolean commandsOnly, boolean isAsync) {
         String[] quoteFormatedArgs = StringFormatter.parseQuotesInArgs(args).toArray(String[]::new);
-        return super.getTabCompletions(sender, alias, quoteFormatedArgs, commandsOnly, isAsync);
+        return super.getTabCompletions(sender, alias, quoteFormatedArgs, commandsOnly, isAsync)
+                .stream()
+                .map(StringFormatter::quoteMultiWordString)
+                .toList();
     }
 }

src/main/java/org/mvplugins/multiverse/core/world/WorldManager.java

@@ -16,6 +16,7 @@
 
 import com.dumptruckman.minecraft.util.Logging;
 import com.google.common.base.Strings;
+import io.papermc.lib.PaperLib;
 import io.vavr.control.Option;
 import io.vavr.control.Try;
 import jakarta.inject.Inject;
@@ -379,7 +380,7 @@ private LoadedMultiverseWorld newLoadedMultiverseWorld(
         // Properties from the bukkit world
         worldConfig.setDifficulty(world.getDifficulty());
         worldConfig.setKeepSpawnInMemory(world.getKeepSpawnInMemory());
-        worldConfig.setScale(world.getCoordinateScale());
+        worldConfig.setScale(getCoordinateScale(world));
 
         worldConfig.save();
 
@@ -398,6 +399,17 @@ private LoadedMultiverseWorld newLoadedMultiverseWorld(
         return loadedWorld;
     }
 
+    private double getCoordinateScale(World world) {
+        if (PaperLib.isPaper()) {
+            return world.getCoordinateScale();
+        }
+        return switch (world.getEnvironment()) {
+            case NORMAL -> 1;
+            case NETHER -> 8;
+            default -> 1;
+        };
+    }
+
     /**
      * Loads an existing world in config.
      *

src/main/java/org/mvplugins/multiverse/core/world/entity/SpawnCategoryConfig.java

@@ -167,20 +167,12 @@ private <N extends Node> N node(N node) {
         final ConfigNode<Integer> tickRate = node(ConfigNode.builder("tick-rate", Integer.class)
                 .defaultValue(-1)
                 .suggester(input -> List.of("-1", "10", "100", "400", "1000"))
-                .validator(input -> config.getApplyEntitySpawnRate()
-                        ? Try.success(null)
-                        : Try.failure(new IllegalStateException("Cannot set tick rate as 'apply-entity-spawn-rate' is false in config. " +
-                        "You can re-enable this option with '/mv config set apply-entity-spawn-rate true' command.")))
                 .onSetValue((oldValue, newValue) -> applyConfigToWorld())
                 .build());
 
         final ConfigNode<Integer> spawnLimit = node(ConfigNode.builder("spawn-limit", Integer.class)
                 .defaultValue(-1)
                 .suggester(input -> List.of("-1", "10", "100", "400", "1000"))
-                .validator(input -> config.getApplyEntitySpawnLimit()
-                        ? Try.success(null)
-                        : Try.failure(new IllegalStateException("Cannot set spawn limit as 'apply-entity-spawn-limit' is false in config. " +
-                        "You can re-enable this option with '/mv config set apply-entity-spawn-limit true' command.")))
                 .onSetValue((oldValue, newValue) -> applyConfigToWorld())
                 .build());