Implement config option for debug permission

Author: benwoo1110

src/main/java/org/mvplugins/multiverse/core/api/MVConfig.java

@@ -270,6 +270,18 @@ public interface MVConfig {
      */
     int getGlobalDebug();
 
+    /**
+     * Sets debugPermissions
+     * @param debugPermissions  The new value
+     */
+    void setDebugPermissions(boolean debugPermissions);
+
+    /**
+     * gets debugPermissions.
+     * @return debugPermissions.
+     */
+    boolean getDebugPermissions();
+
     /**
      * Sets whether to suppress startup messages.
      *

src/main/java/org/mvplugins/multiverse/core/commandtools/MVCommandPermissions.java

@@ -19,10 +19,12 @@
 @Service
 public class MVCommandPermissions {
     private final Map<String, Predicate<CommandIssuer>> permissionsCheckMap;
+    private final CorePermissionsChecker permissionsChecker;
 
     @Inject
     MVCommandPermissions(@NotNull CorePermissionsChecker permissionsChecker) {
-        permissionsCheckMap = new HashMap<>();
+        this.permissionsCheckMap = new HashMap<>();
+        this.permissionsChecker = permissionsChecker;
 
         registerPermissionChecker("mvteleport", issuer -> permissionsChecker.hasAnyTeleportPermission(issuer.getIssuer()));
         registerPermissionChecker("mvspawn", issuer -> permissionsChecker.hasAnySpawnPermission(issuer.getIssuer()));
@@ -52,6 +54,6 @@ public void registerPermissionChecker(String id, Predicate<CommandIssuer> checke
     boolean hasPermission(CommandIssuer issuer, String permission) {
         return Option.of(permissionsCheckMap.get(permission))
                 .map(checker -> checker.test(issuer))
-                .getOrElse(() -> issuer.hasPermission(permission));
+                .getOrElse(() -> permissionsChecker.hasPermission(issuer.getIssuer(), permission));
     }
 }

src/main/java/org/mvplugins/multiverse/core/config/MVCoreConfig.java

@@ -354,6 +354,16 @@ public int getGlobalDebug() {
         return configHandle.get(configNodes.GLOBAL_DEBUG);
     }
 
+    @Override
+    public void setDebugPermissions(boolean debugPermissions) {
+        configHandle.set(configNodes.DEBUG_PERMISSIONS, debugPermissions);
+    }
+
+    @Override
+    public boolean getDebugPermissions() {
+        return configHandle.get(configNodes.DEBUG_PERMISSIONS);
+    }
+
     @Override
     public void setSilentStart(boolean silentStart) {
         configHandle.set(configNodes.SILENT_START, silentStart);

src/main/java/org/mvplugins/multiverse/core/config/MVCoreConfigNodes.java

@@ -306,7 +306,7 @@ private <N extends Node> N node(N node) {
             .defaultValue(0)
             .name("global-debug")
             .validator(value -> (value < 0 || value > 3)
-                    ? Try.failure(new MultiverseException("Debug level must be between 0 and 3.", null))
+                    ? Try.failure(new MultiverseException("Debug level must be between 0 and 3."))
                     : Try.success(null))
             .onSetValue((oldValue, newValue) -> {
                 int level = Logging.getDebugLevel();
@@ -317,6 +317,13 @@ private <N extends Node> N node(N node) {
             })
             .build());
 
+    final ConfigNode<Boolean> DEBUG_PERMISSIONS = node(ConfigNode.builder("misc.debug-permissions", Boolean.class)
+            .comment("Sets whether console will log every permission check done by all multiverse plugins.")
+            .comment("This will only work if the above 'global-debug' is set to 1 or more.")
+            .defaultValue(false)
+            .name("debug-permissions")
+            .build());
+
     final ConfigNode<Boolean> SILENT_START = node(ConfigNode.builder("misc.silent-start", Boolean.class)
             .comment("")
             .comment("If true, the startup console messages will no longer show.")

src/main/java/org/mvplugins/multiverse/core/permissions/CorePermissionsChecker.java

@@ -127,16 +127,34 @@ public boolean hasAnyTeleportPermission(CommandSender sender) {
         return false;
     }
 
-    private String concatPermission(String permission, String... child) {
+    /**
+     * Joins permissions with a dot.
+     *
+     * @param permission    The permission
+     * @param child         The string(s) to join
+     * @return The newly joined permission node.
+     */
+    public String concatPermission(String permission, String... child) {
         return permission + "." + String.join(".", child);
     }
 
-    private boolean hasPermission(CommandSender sender, String permission) {
+    /**
+     * Check and log if the sender has the permission.
+     *
+     * @param sender        The sender
+     * @param permission    The permission
+     * @return True if the sender has the permission, else false.
+     */
+    public boolean hasPermission(CommandSender sender, String permission) {
         if (sender.hasPermission(permission)) {
-            Logging.finer("Checking to see if sender [%s] has permission [%s]... YES", sender.getName(), permission);
+            if (config.getDebugPermissions()) {
+                Logging.finer("Checking sender [%s] has permission [%s] : YES", sender.getName(), permission);
+            }
             return true;
         }
-        Logging.finer("Checking to see if sender [%s] has permission [%s]... NO", sender.getName(), permission);
+        if (config.getDebugPermissions()) {
+            Logging.finer("Checking sender [%s] has permission [%s] : NO", sender.getName(), permission);
+        }
         return false;
     }
 }