Skip to content

Commit a55ce68

Browse files
authored
Merge pull request #3254 from Multiverse/fix/world-chart
Fix bstats world chart
2 parents abd6983 + 3e47460 commit a55ce68

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

src/main/java/org/mvplugins/multiverse/core/BstatsMetricsConfigurator.java

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import java.util.HashMap;
44
import java.util.Map;
5+
import java.util.concurrent.Callable;
56
import java.util.function.Consumer;
67

78
import com.dumptruckman.minecraft.util.Logging;
@@ -10,7 +11,7 @@
1011
import org.apache.commons.lang3.text.WordUtils;
1112
import org.bstats.bukkit.Metrics;
1213
import org.bstats.charts.AdvancedPie;
13-
import org.bstats.charts.MultiLineChart;
14+
import org.bstats.charts.SingleLineChart;
1415
import org.bukkit.World;
1516
import org.jvnet.hk2.annotations.Service;
1617

@@ -79,18 +80,15 @@ private String titleCaseEnv(World.Environment env) {
7980
}
8081

8182
private void addWorldCountMetric() {
82-
addMultiLineMetric("world_count", map -> {
83-
map.put("Loaded worlds", worldManager.getLoadedWorlds().size());
84-
map.put("Total number of worlds", worldManager.getWorlds().size());
85-
});
83+
addLineMetric("worlds", () -> worldManager.getWorlds().size());
8684
}
8785

8886
private void addAdvancedPieMetric(String chartId, Consumer<Map<String, Integer>> metricsFunc) {
8987
metrics.addCustomChart(createAdvancedPieChart(chartId, metricsFunc));
9088
}
9189

92-
private void addMultiLineMetric(String chartId, Consumer<Map<String, Integer>> metricsFunc) {
93-
metrics.addCustomChart(createMultiLineChart(chartId, metricsFunc));
90+
private void addLineMetric(String chartId, Callable<Integer> metricsFunc) {
91+
metrics.addCustomChart(createLineChart(chartId, metricsFunc));
9492
}
9593

9694
private void incrementCount(Map<String, Integer> map, String key) {
@@ -104,9 +102,7 @@ private AdvancedPie createAdvancedPieChart(String chartId, Consumer<Map<String,
104102
return new AdvancedPie(chartId, () -> map);
105103
}
106104

107-
private MultiLineChart createMultiLineChart(String chartId, Consumer<Map<String, Integer>> metricsFunc) {
108-
Map<String, Integer> map = new HashMap<>();
109-
metricsFunc.accept(map);
110-
return new MultiLineChart(chartId, () -> map);
105+
private SingleLineChart createLineChart(String chartId, Callable<Integer> metricsFunc) {
106+
return new SingleLineChart(chartId, metricsFunc);
111107
}
112108
}

0 commit comments

Comments
 (0)