Merge pull request #649 from Multiverse/fix/handling-state

Delay handling state to end of profile writes

Author: benwoo1110

src/main/java/org/mvplugins/multiverse/inventories/handleshare/PlayerShareHandlingState.java

@@ -6,9 +6,9 @@
 import org.mvplugins.multiverse.external.jakarta.inject.Inject;
 import org.mvplugins.multiverse.inventories.share.Sharable;
 
-import java.util.HashMap;
 import java.util.Map;
 import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
 
 /**
  * Keeps track of players who are currently having their sharable handling processed.
@@ -26,7 +26,7 @@ public final class PlayerShareHandlingState {
 
     @Inject
     PlayerShareHandlingState() {
-         this.playerAffectedProfiles = new HashMap<>();
+         this.playerAffectedProfiles = new ConcurrentHashMap<>();
     }
 
     void setPlayerAffectedProfiles(Player player, AffectedProfiles status) {

src/main/java/org/mvplugins/multiverse/inventories/handleshare/ShareHandler.java

@@ -93,7 +93,6 @@ private void updatePlayer() {
         for (PersistingProfile readProfile : affectedProfiles.getReadProfiles()) {
             ShareHandlingUpdater.updatePlayer(inventories, player, readProfile);
         }
-        playerShareHandlingState.removePlayerAffectedProfiles(player);
     }
 
     private CompletableFuture<Void> updateProfiles(ProfileDataSnapshot snapshot) {
@@ -104,7 +103,8 @@ private CompletableFuture<Void> updateProfiles(ProfileDataSnapshot snapshot) {
         return CompletableFuture.allOf(affectedProfiles.getWriteProfiles()
                 .stream()
                 .map(writeProfile -> updatePersistingProfile(writeProfile, snapshot))
-                .toArray(CompletableFuture[]::new));
+                .toArray(CompletableFuture[]::new))
+                .thenRun(() -> playerShareHandlingState.removePlayerAffectedProfiles(player));
     }
 
     private CompletableFuture<Void> updatePersistingProfile(PersistingProfile persistingProfile, ProfileDataSnapshot snapshot) {