fix: update deploy to qa job (#106)

Author: Hassim Naseef M

.github/workflows/deploy-qa.yml

@@ -10,7 +10,7 @@ on:
 
 permissions:
   id-token: write
-  contents: read
+  contents: write
 
 env:
   CHARTS_DIR: charts
@@ -44,10 +44,15 @@ jobs:
         run: |
           base=$(yq '.version' "$CHART_PATH/Chart.yaml")
           short=${GITHUB_SHA::7}
-          ver="${base}-pr${{ github.event.number }}+${short}"
+          ver="${base}-pr${{ github.event.number }}-${short}"
           yq -i ".version = \"${ver}\"" "$CHART_PATH/Chart.yaml"
           echo "ver=$ver" >> $GITHUB_OUTPUT
 
+      - name: Configure git identity for AISQUARED_CI_BOT
+        run: |
+          git config --global user.name "AISQUARED-CI-BOT[bot]"
+          git config --global user.email "1447931+AISQUARED-CI-BOT[bot]@users.noreply.github.com"
+
       - name: Release with chart-releaser
         uses: helm/[email protected]
         env:
@@ -89,9 +94,9 @@ jobs:
       - name: Bump dependency version and update lock
         working-directory: infra/${{ env.INFRA_PATH }}
         run: |
-          ver="${{ needs.publish_pr_chart.outputs.ver }}"
+          export ver="${{ needs.publish_pr_chart.outputs.ver }}"
           yq -i ".dependencies[] |= ( if .name == \"${{ env.CHART_NAME }}\" then .version = \"${ver}\" else . end )" Chart.yaml
-          helm dependency update .
+          cat Chart.yaml
 
       - name: Commit to a temporary branch
         working-directory: infra
@@ -100,8 +105,8 @@ jobs:
         run: |
           git switch -c "$BRANCH_NAME" 2>/dev/null || git switch "$BRANCH_NAME"
           git add -A
-          git -c user.name="github-actions[bot]" \
-              -c user.email="41898282+github-actions[bot]@users.noreply.github.com" \
+          git -c user.name="AISQUARED-CI-BOT[bot]" \
+              -c user.email="1447931+AISQUARED-CI-BOT[bot]@users.noreply.github.com" \
               commit -m "test(qa): bump ${{ env.CHART_NAME }} to ${{ needs.publish_pr_chart.outputs.ver }}"
           git push -u origin "$BRANCH_NAME" --force
 
@@ -112,6 +117,9 @@ jobs:
           curl -sSL -o argocd https://github.com/argoproj/argo-cd/releases/download/v2.12.3/argocd-linux-amd64
           chmod +x argocd && sudo mv argocd /usr/local/bin/argocd
 
+          echo "sleeping till chart is ready"
+          sleep 100
+
           # Point app at the temp branch
           argocd app set "${{ env.ARGOCD_APP }}" \
             --server "${{ env.ARGOCD_SERVER_HOST }}" \