net/AddressInfo: remove MakeAddrInfo()

Use designated initializers instead.

Author: MaxKellermann

src/net/AddressInfo.hxx

@@ -14,17 +14,6 @@
 #include <netdb.h> // IWYU pragma: export
 #endif
 
-constexpr struct addrinfo
-MakeAddrInfo(int flags, int family, int socktype, int protocol=0) noexcept
-{
-	struct addrinfo ai{};
-	ai.ai_flags = flags;
-	ai.ai_family = family;
-	ai.ai_socktype = socktype;
-	ai.ai_protocol = protocol;
-	return ai;
-}
-
 class AddressInfo : addrinfo {
 	/* this class cannot be instantiated, it can only be cast from
 	   a struct addrinfo pointer */

src/net/Resolver.cxx

@@ -122,6 +122,11 @@ Resolve(const char *host_and_port, int default_port,
 AddressInfoList
 Resolve(const char *host_port, unsigned default_port, int flags, int socktype)
 {
-	const auto hints = MakeAddrInfo(flags, AF_UNSPEC, socktype);
+	const struct addrinfo hints{
+		.ai_flags = flags,
+		.ai_family = AF_UNSPEC,
+		.ai_socktype = socktype,
+	};
+
 	return Resolve(host_port, default_port, &hints);
 }