Skip to content

Commit e61caad

Browse files
raikonenfnuMuzammiluddin-Syed-ECE
authored andcommitted
Revert "[mlir] add a fluent API to GreedyRewriterConfig (llvm#137122)"
This reverts commit 0c61b24.
1 parent 07108a8 commit e61caad

30 files changed

+168
-224
lines changed

flang/lib/Optimizer/CodeGen/LowerRepackArrays.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -357,8 +357,8 @@ class LowerRepackArraysPass
357357
patterns.insert<PackArrayConversion>(context);
358358
patterns.insert<UnpackArrayConversion>(context);
359359
mlir::GreedyRewriteConfig config;
360-
config.setRegionSimplificationLevel(
361-
mlir::GreedySimplifyRegionLevel::Disabled);
360+
config.enableRegionSimplification =
361+
mlir::GreedySimplifyRegionLevel::Disabled;
362362
(void)applyPatternsGreedily(module, std::move(patterns), config);
363363
}
364364

flang/lib/Optimizer/HLFIR/Transforms/InlineElementals.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ class InlineElementalsPass
119119

120120
mlir::GreedyRewriteConfig config;
121121
// Prevent the pattern driver from merging blocks.
122-
config.setRegionSimplificationLevel(
123-
mlir::GreedySimplifyRegionLevel::Disabled);
122+
config.enableRegionSimplification =
123+
mlir::GreedySimplifyRegionLevel::Disabled;
124124

125125
mlir::RewritePatternSet patterns(context);
126126
patterns.insert<InlineElementalConversion>(context);

flang/lib/Optimizer/HLFIR/Transforms/InlineHLFIRAssign.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ class InlineHLFIRAssignPass
135135

136136
mlir::GreedyRewriteConfig config;
137137
// Prevent the pattern driver from merging blocks.
138-
config.setRegionSimplificationLevel(
139-
mlir::GreedySimplifyRegionLevel::Disabled);
138+
config.enableRegionSimplification =
139+
mlir::GreedySimplifyRegionLevel::Disabled;
140140

141141
mlir::RewritePatternSet patterns(context);
142142
patterns.insert<InlineHLFIRAssignConversion>(context);

flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIRIntrinsics.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -557,8 +557,8 @@ class LowerHLFIRIntrinsics
557557
// Pattern rewriting only requires that the resulting IR is still valid
558558
mlir::GreedyRewriteConfig config;
559559
// Prevent the pattern driver from merging blocks
560-
config.setRegionSimplificationLevel(
561-
mlir::GreedySimplifyRegionLevel::Disabled);
560+
config.enableRegionSimplification =
561+
mlir::GreedySimplifyRegionLevel::Disabled;
562562

563563
if (mlir::failed(
564564
mlir::applyPatternsGreedily(module, std::move(patterns), config))) {

flang/lib/Optimizer/HLFIR/Transforms/OptimizedBufferization.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -875,8 +875,8 @@ class OptimizedBufferizationPass
875875

876876
mlir::GreedyRewriteConfig config;
877877
// Prevent the pattern driver from merging blocks
878-
config.setRegionSimplificationLevel(
879-
mlir::GreedySimplifyRegionLevel::Disabled);
878+
config.enableRegionSimplification =
879+
mlir::GreedySimplifyRegionLevel::Disabled;
880880

881881
mlir::RewritePatternSet patterns(context);
882882
// TODO: right now the patterns are non-conflicting,

flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2331,8 +2331,8 @@ class SimplifyHLFIRIntrinsics
23312331

23322332
mlir::GreedyRewriteConfig config;
23332333
// Prevent the pattern driver from merging blocks
2334-
config.setRegionSimplificationLevel(
2335-
mlir::GreedySimplifyRegionLevel::Disabled);
2334+
config.enableRegionSimplification =
2335+
mlir::GreedySimplifyRegionLevel::Disabled;
23362336

23372337
mlir::RewritePatternSet patterns(context);
23382338
patterns.insert<TransposeAsElementalConversion>(context);

flang/lib/Optimizer/Passes/Pipelines.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ void addNestedPassToAllTopLevelOperationsConditionally(
3535

3636
void addCanonicalizerPassWithoutRegionSimplification(mlir::OpPassManager &pm) {
3737
mlir::GreedyRewriteConfig config;
38-
config.setRegionSimplificationLevel(
39-
mlir::GreedySimplifyRegionLevel::Disabled);
38+
config.enableRegionSimplification = mlir::GreedySimplifyRegionLevel::Disabled;
4039
pm.addPass(mlir::createCanonicalizerPass(config));
4140
}
4241

@@ -164,8 +163,7 @@ void createDefaultFIROptimizerPassPipeline(mlir::PassManager &pm,
164163

165164
// simplify the IR
166165
mlir::GreedyRewriteConfig config;
167-
config.setRegionSimplificationLevel(
168-
mlir::GreedySimplifyRegionLevel::Disabled);
166+
config.enableRegionSimplification = mlir::GreedySimplifyRegionLevel::Disabled;
169167
pm.addPass(mlir::createCSEPass());
170168
fir::addAVC(pm, pc.OptLevel);
171169
addNestedPassToAllTopLevelOperations<PassConstructor>(

flang/lib/Optimizer/Transforms/AssumedRankOpConversion.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,8 @@ class AssumedRankOpConversion
152152
patterns.insert<ReboxAssumedRankConv>(context, &symbolTable, kindMap);
153153
patterns.insert<IsAssumedSizeConv>(context, &symbolTable, kindMap);
154154
mlir::GreedyRewriteConfig config;
155-
config.setRegionSimplificationLevel(
156-
mlir::GreedySimplifyRegionLevel::Disabled);
155+
config.enableRegionSimplification =
156+
mlir::GreedySimplifyRegionLevel::Disabled;
157157
(void)applyPatternsGreedily(mod, std::move(patterns), config);
158158
}
159159
};

flang/lib/Optimizer/Transforms/ConstantArgumentGlobalisation.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,9 @@ class ConstantArgumentGlobalisationOpt
168168
auto *context = &getContext();
169169
mlir::RewritePatternSet patterns(context);
170170
mlir::GreedyRewriteConfig config;
171-
config.setRegionSimplificationLevel(
172-
mlir::GreedySimplifyRegionLevel::Disabled);
173-
config.setStrictness(mlir::GreedyRewriteStrictness::ExistingOps);
171+
config.enableRegionSimplification =
172+
mlir::GreedySimplifyRegionLevel::Disabled;
173+
config.strictMode = mlir::GreedyRewriteStrictness::ExistingOps;
174174

175175
patterns.insert<CallOpRewriter>(context, *di);
176176
if (mlir::failed(

flang/lib/Optimizer/Transforms/SimplifyFIROperations.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,8 +268,7 @@ void SimplifyFIROperationsPass::runOnOperation() {
268268
fir::populateSimplifyFIROperationsPatterns(patterns,
269269
preferInlineImplementation);
270270
mlir::GreedyRewriteConfig config;
271-
config.setRegionSimplificationLevel(
272-
mlir::GreedySimplifyRegionLevel::Disabled);
271+
config.enableRegionSimplification = mlir::GreedySimplifyRegionLevel::Disabled;
273272

274273
if (mlir::failed(
275274
mlir::applyPatternsGreedily(module, std::move(patterns), config))) {

0 commit comments

Comments
 (0)