Skip to content

Commit 1b525a7

Browse files
oliverkleeoliverklee
committed
[TASK] Raise PHPStan to level 7
https://phpstan.org/user-guide/rule-levels
1 parent 6f07de2 commit 1b525a7

File tree

2 files changed

+211
-1
lines changed

2 files changed

+211
-1
lines changed

‎config/phpstan-baseline.neon‎

Lines changed: 210 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,35 @@
11
parameters:
22
ignoreErrors:
3+
-
4+
message: '#^Only booleans are allowed in an if condition, Sabberworm\\CSS\\CSSList\\CSSListItem\|false given\.$#'
5+
identifier: if.condNotBoolean
6+
count: 1
7+
path: ../src/CSSList/CSSList.php
8+
9+
-
10+
message: '#^Parameter \#1 \$animationName of method Sabberworm\\CSS\\CSSList\\KeyFrame\:\:setAnimationName\(\) expects non\-empty\-string, string given\.$#'
11+
identifier: argument.type
12+
count: 1
13+
path: ../src/CSSList/CSSList.php
14+
315
-
416
message: '#^Parameter \#2 \$found of class Sabberworm\\CSS\\Parsing\\UnexpectedTokenException constructor expects string, Sabberworm\\CSS\\Value\\CSSFunction\|Sabberworm\\CSS\\Value\\CSSString\|Sabberworm\\CSS\\Value\\LineName\|Sabberworm\\CSS\\Value\\Size\|Sabberworm\\CSS\\Value\\URL given\.$#'
517
identifier: argument.type
618
count: 1
719
path: ../src/CSSList/CSSList.php
820

21+
-
22+
message: '#^Parameter \#2 \$found of class Sabberworm\\CSS\\Parsing\\UnexpectedTokenException constructor expects string, Sabberworm\\CSS\\Value\\CSSFunction\|Sabberworm\\CSS\\Value\\LineName\|Sabberworm\\CSS\\Value\\Size\|string given\.$#'
23+
identifier: argument.type
24+
count: 1
25+
path: ../src/CSSList/CSSList.php
26+
27+
-
28+
message: '#^Parameter \#2 \$selectors2 of static method Sabberworm\\CSS\\CSSList\\CSSList\:\:selectorsMatch\(\) expects list\<Sabberworm\\CSS\\Property\\Selector\>, array\<Sabberworm\\CSS\\Property\\Selector\|string\> given\.$#'
29+
identifier: argument.type
30+
count: 1
31+
path: ../src/CSSList/CSSList.php
32+
933
-
1034
message: '#^Parameters should have "Sabberworm\\CSS\\CSSList\\CSSListItem\|array" types as the only types passed to this method$#'
1135
identifier: typePerfect.narrowPublicClassMethodParamType
@@ -18,24 +42,84 @@ parameters:
1842
count: 1
1943
path: ../src/CSSList/Document.php
2044

45+
-
46+
message: '#^Method Sabberworm\\CSS\\Comment\\Comment\:\:getShortClassName\(\) should return non\-empty\-string but returns string\.$#'
47+
identifier: return.type
48+
count: 1
49+
path: ../src/Comment/Comment.php
50+
51+
-
52+
message: '#^Method Sabberworm\\CSS\\Parsing\\ParserState\:\:parseIdentifier\(\) should return non\-empty\-string but returns string\.$#'
53+
identifier: return.type
54+
count: 1
55+
path: ../src/Parsing/ParserState.php
56+
57+
-
58+
message: '#^Method Sabberworm\\CSS\\Parsing\\ParserState\:\:strlen\(\) should return int\<0, max\> but returns int\<0, max\>\|false\.$#'
59+
identifier: return.type
60+
count: 1
61+
path: ../src/Parsing/ParserState.php
62+
2163
-
2264
message: '#^Negated boolean expression is always true\.$#'
2365
identifier: booleanNot.alwaysTrue
2466
count: 1
2567
path: ../src/Parsing/ParserState.php
2668

69+
-
70+
message: '#^Property Sabberworm\\CSS\\Parsing\\ParserState\:\:\$currentPosition \(int\<0, max\>\) does not accept int\.$#'
71+
identifier: assign.propertyType
72+
count: 2
73+
path: ../src/Parsing/ParserState.php
74+
75+
-
76+
message: '#^Parameter \#1 \$separator of class Sabberworm\\CSS\\Value\\RuleValueList constructor expects non\-empty\-string, string given\.$#'
77+
identifier: argument.type
78+
count: 1
79+
path: ../src/Rule/Rule.php
80+
81+
-
82+
message: '#^Parameter \#1 \$value of method Sabberworm\\CSS\\Rule\\Rule\:\:setValue\(\) expects Sabberworm\\CSS\\Value\\RuleValueList\|string\|null, Sabberworm\\CSS\\Value\\Value\|string given\.$#'
83+
identifier: argument.type
84+
count: 1
85+
path: ../src/Rule/Rule.php
86+
2787
-
2888
message: '#^Parameters should have "string" types as the only types passed to this method$#'
2989
identifier: typePerfect.narrowPublicClassMethodParamType
3090
count: 1
3191
path: ../src/RuleSet/DeclarationBlock.php
3292

93+
-
94+
message: '#^Property Sabberworm\\CSS\\RuleSet\\DeclarationBlock\:\:\$selectors \(list\<Sabberworm\\CSS\\Property\\Selector\>\) does not accept array\<int\<0, max\>, Sabberworm\\CSS\\Property\\Selector\>\.$#'
95+
identifier: assign.propertyType
96+
count: 1
97+
path: ../src/RuleSet/DeclarationBlock.php
98+
99+
-
100+
message: '#^Property Sabberworm\\CSS\\RuleSet\\DeclarationBlock\:\:\$selectors \(list\<Sabberworm\\CSS\\Property\\Selector\>\) does not accept list\<Sabberworm\\CSS\\Property\\Selector\|string\>\.$#'
101+
identifier: assign.propertyType
102+
count: 1
103+
path: ../src/RuleSet/DeclarationBlock.php
104+
105+
-
106+
message: '#^Parameter \#1 \$name of class Sabberworm\\CSS\\Value\\CSSFunction constructor expects non\-empty\-string, string given\.$#'
107+
identifier: argument.type
108+
count: 1
109+
path: ../src/Value/CSSFunction.php
110+
33111
-
34112
message: '#^Parameter \#2 \$arguments of class Sabberworm\\CSS\\Value\\CSSFunction constructor expects array\<Sabberworm\\CSS\\Value\\Value\|string\>\|Sabberworm\\CSS\\Value\\RuleValueList, Sabberworm\\CSS\\Value\\Value\|string given\.$#'
35113
identifier: argument.type
36114
count: 1
37115
path: ../src/Value/CSSFunction.php
38116

117+
-
118+
message: '#^Method Sabberworm\\CSS\\Value\\CSSString\:\:getShortClassName\(\) should return non\-empty\-string but returns string\.$#'
119+
identifier: return.type
120+
count: 1
121+
path: ../src/Value/CSSString.php
122+
39123
-
40124
message: '#^Parameter \#2 \$offset of method Sabberworm\\CSS\\Parsing\\ParserState\:\:peek\(\) expects int\<0, max\>, \-1 given\.$#'
41125
identifier: argument.type
@@ -48,6 +132,30 @@ parameters:
48132
count: 3
49133
path: ../src/Value/Color.php
50134

135+
-
136+
message: '#^Parameter \#1 \$name of method Sabberworm\\CSS\\Value\\CSSFunction\:\:__construct\(\) expects non\-empty\-string, string given\.$#'
137+
identifier: argument.type
138+
count: 1
139+
path: ../src/Value/Color.php
140+
141+
-
142+
message: '#^Parameter \#1 \$name of method Sabberworm\\CSS\\Value\\CSSFunction\:\:setName\(\) expects non\-empty\-string, string given\.$#'
143+
identifier: argument.type
144+
count: 1
145+
path: ../src/Value/Color.php
146+
147+
-
148+
message: '#^Method Sabberworm\\CSS\\Value\\Size\:\:getShortClassName\(\) should return non\-empty\-string but returns string\.$#'
149+
identifier: return.type
150+
count: 1
151+
path: ../src/Value/Size.php
152+
153+
-
154+
message: '#^Method Sabberworm\\CSS\\Value\\Size\:\:render\(\) should return non\-empty\-string but returns string\.$#'
155+
identifier: return.type
156+
count: 1
157+
path: ../src/Value/Size.php
158+
51159
-
52160
message: '#^Parameters should have "float" types as the only types passed to this method$#'
53161
identifier: typePerfect.narrowPublicClassMethodParamType
@@ -60,6 +168,24 @@ parameters:
60168
count: 1
61169
path: ../src/Value/Size.php
62170

171+
-
172+
message: '#^Method Sabberworm\\CSS\\Value\\URL\:\:getShortClassName\(\) should return non\-empty\-string but returns string\.$#'
173+
identifier: return.type
174+
count: 1
175+
path: ../src/Value/URL.php
176+
177+
-
178+
message: '#^Method Sabberworm\\CSS\\Value\\Value\:\:parseIdentifierOrFunction\(\) should return Sabberworm\\CSS\\Value\\CSSFunction\|string but returns Sabberworm\\CSS\\Value\\CSSFunction\|Sabberworm\\CSS\\Value\\URL\|string\.$#'
179+
identifier: return.type
180+
count: 1
181+
path: ../src/Value/Value.php
182+
183+
-
184+
message: '#^Parameter \#1 \$name of class Sabberworm\\CSS\\Value\\CSSFunction constructor expects non\-empty\-string, string given\.$#'
185+
identifier: argument.type
186+
count: 1
187+
path: ../src/Value/Value.php
188+
63189
-
64190
message: '#^Parameter \#2 \$arguments of class Sabberworm\\CSS\\Value\\CSSFunction constructor expects array\<Sabberworm\\CSS\\Value\\Value\|string\>\|Sabberworm\\CSS\\Value\\RuleValueList, Sabberworm\\CSS\\Value\\Value\|string given\.$#'
65191
identifier: argument.type
@@ -72,12 +198,42 @@ parameters:
72198
count: 1
73199
path: ../src/Value/Value.php
74200

201+
-
202+
message: '#^Method Sabberworm\\CSS\\Value\\ValueList\:\:getShortClassName\(\) should return non\-empty\-string but returns string\.$#'
203+
identifier: return.type
204+
count: 1
205+
path: ../src/Value/ValueList.php
206+
207+
-
208+
message: '#^Parameter \#1 \$rule of class Sabberworm\\CSS\\Rule\\Rule constructor expects non\-empty\-string, string given\.$#'
209+
identifier: argument.type
210+
count: 1
211+
path: ../tests/Functional/RuleSet/RuleSetTest.php
212+
75213
-
76214
message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertSame\(\) with ''red'' and Sabberworm\\CSS\\Value\\Value will always evaluate to false\.$#'
77215
identifier: staticMethod.impossibleType
78216
count: 1
79217
path: ../tests/ParserTest.php
80218

219+
-
220+
message: '#^Cannot call method getListComponents\(\) on Sabberworm\\CSS\\Value\\RuleValueList\|string\.$#'
221+
identifier: method.nonObject
222+
count: 2
223+
path: ../tests/ParserTest.php
224+
225+
-
226+
message: '#^Cannot call method getListSeparator\(\) on Sabberworm\\CSS\\Value\\RuleValueList\|string\.$#'
227+
identifier: method.nonObject
228+
count: 2
229+
path: ../tests/ParserTest.php
230+
231+
-
232+
message: '#^Cannot call method render\(\) on Sabberworm\\CSS\\Value\\RuleValueList\|string\.$#'
233+
identifier: method.nonObject
234+
count: 1
235+
path: ../tests/ParserTest.php
236+
81237
-
82238
message: '#^Parameter \#1 \$value of method Sabberworm\\CSS\\Rule\\Rule\:\:setValue\(\) expects Sabberworm\\CSS\\Value\\RuleValueList\|string\|null, Sabberworm\\CSS\\Value\\Size given\.$#'
83239
identifier: argument.type
@@ -107,3 +263,57 @@ parameters:
107263
identifier: argument.type
108264
count: 2
109265
path: ../tests/Unit/CSSList/CSSListTest.php
266+
267+
-
268+
message: '#^Method Sabberworm\\CSS\\Tests\\Unit\\Comment\\CommentContainerTest\:\:provideAlternativeNonemptyCommentArray\(\) should return array\<non\-empty\-string, array\{non\-empty\-list\<Sabberworm\\CSS\\Comment\\Comment\>\}\> but returns array\<non\-empty\-string, array\{list\<Sabberworm\\CSS\\Comment\\Comment\>\}\>\.$#'
269+
identifier: return.type
270+
count: 1
271+
path: ../tests/Unit/Comment/CommentContainerTest.php
272+
273+
-
274+
message: '#^Method Sabberworm\\CSS\\Tests\\Unit\\Fixtures\\ConcreteShortClassNameProvider\:\:getShortClassName\(\) should return non\-empty\-string but returns string\.$#'
275+
identifier: return.type
276+
count: 1
277+
path: ../tests/Unit/Fixtures/ConcreteShortClassNameProvider.php
278+
279+
-
280+
message: '#^Parameter \#1 \$numberOfSpaces of method Sabberworm\\CSS\\OutputFormat\:\:indentWithSpaces\(\) expects int\<1, max\>, int given\.$#'
281+
identifier: argument.type
282+
count: 1
283+
path: ../tests/Unit/OutputFormatTest.php
284+
285+
-
286+
message: '#^Parameter \#1 \$numberOfTabs of method Sabberworm\\CSS\\OutputFormat\:\:indentWithTabs\(\) expects int\<1, max\>, int given\.$#'
287+
identifier: argument.type
288+
count: 1
289+
path: ../tests/Unit/OutputFormatTest.php
290+
291+
-
292+
message: '#^Parameter \#1 \$lineNumber of method Sabberworm\\CSS\\Tests\\Unit\\Position\\Fixtures\\ConcretePosition\:\:setPosition\(\) expects int\<1, max\>\|null, int given\.$#'
293+
identifier: argument.type
294+
count: 2
295+
path: ../tests/Unit/Position/PositionTest.php
296+
297+
-
298+
message: '#^Parameter \#2 \$columnNumber of method Sabberworm\\CSS\\Tests\\Unit\\Position\\Fixtures\\ConcretePosition\:\:setPosition\(\) expects int\<0, max\>\|null, int given\.$#'
299+
identifier: argument.type
300+
count: 3
301+
path: ../tests/Unit/Position/PositionTest.php
302+
303+
-
304+
message: '#^Parameter \#1 \$rule of class Sabberworm\\CSS\\Rule\\Rule constructor expects non\-empty\-string, string given\.$#'
305+
identifier: argument.type
306+
count: 19
307+
path: ../tests/Unit/RuleSet/DeclarationBlockTest.php
308+
309+
-
310+
message: '#^Parameter \#1 \$rule of class Sabberworm\\CSS\\Rule\\Rule constructor expects non\-empty\-string, string given\.$#'
311+
identifier: argument.type
312+
count: 19
313+
path: ../tests/Unit/RuleSet/RuleSetTest.php
314+
315+
-
316+
message: '#^Cannot call method getArrayRepresentation\(\) on Sabberworm\\CSS\\Value\\Value\|string\.$#'
317+
identifier: method.nonObject
318+
count: 1
319+
path: ../tests/Unit/Value/ValueTest.php

‎config/phpstan.neon‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ parameters:
88

99
phpVersion: 70200
1010

11-
level: 6
11+
level: 7
1212

1313
paths:
1414
- %currentWorkingDirectory%/bin/

0 commit comments

Comments
 (0)