Skip to content

Commit 2ce7276

Browse files
committed
[TASK] Deprecate method forwarding OutputFormat to OutputFormatter
Instead, the corresponding method on the formatter should be called directly. This increases type safety and helps static code analysis. Also, it makes the code easier to understand.
1 parent e725c2e commit 2ce7276

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ Please also have a look at our
3232

3333
### Deprecated
3434

35+
- Deprecate magic method forwarding from `OutputFormat` to `OutputFormatter`
36+
(#894)
3537
- `OutputFormat` properties for space around list separators as an array (#880)
3638

3739
### Removed

src/OutputFormat.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,7 @@ public function set($aNames, $mValue)
294294
public function __call(string $sMethodName, array $aArguments)
295295
{
296296
if (\method_exists(OutputFormatter::class, $sMethodName)) {
297+
// @deprecated since 8.8.0, will be removed in 9.0.0. Call the method on the formatter directly instead.
297298
return \call_user_func_array([$this->getFormatter(), $sMethodName], $aArguments);
298299
} else {
299300
throw new \Exception('Unknown OutputFormat method called: ' . $sMethodName);

0 commit comments

Comments
 (0)