[TASK] Drop greedy calculation of selector specificity

oliverklee · oliverklee · commit 34e1988fb7e3 · 2025-03-02T15:08:37.000+01:00
This constructor parameter is not used, and having the
specificity calculation always done lazily is not a problem.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -40,6 +40,7 @@ Please also have a look at our
 
 ### Removed
 
+- Drop greedy calculation of selector specificity (#1021)
 - Drop `getLineNo()` from the `Renderable` interface (#1038)
 - Remove `OutputFormat::level()` (#874)
 - Remove expansion of shorthand properties (#838)
diff --git a/src/Property/Selector.php b/src/Property/Selector.php
@@ -87,15 +87,9 @@ public static function isValid(string $selector)
         return \preg_match(static::SELECTOR_VALIDATION_RX, $selector);
     }
 
-    /**
-     * @param bool $calculateSpecificity @deprecated since V8.8.0, will be removed in V9.0.0
-     */
-    public function __construct(string $selector, bool $calculateSpecificity = false)
+    public function __construct(string $selector)
     {
         $this->setSelector($selector);
-        if ($calculateSpecificity) {
-            $this->getSpecificity();
-        }
     }
 
     public function getSelector(): string

Original file line number	Diff line number	Diff line change
`@@ -87,15 +87,9 @@ public static function isValid(string $selector)`
`87`	`87`	`return \preg_match(static::SELECTOR_VALIDATION_RX, $selector);`
`88`	`88`	`}`
`89`	`89`
`90`		`- /**`
`91`		`- * @param bool $calculateSpecificity @deprecated since V8.8.0, will be removed in V9.0.0`
`92`		`- */`
`93`		`- public function __construct(string $selector, bool $calculateSpecificity = false)`
	`90`	`+ public function __construct(string $selector)`
`94`	`91`	`{`
`95`	`92`	`$this->setSelector($selector);`
`96`		`- if ($calculateSpecificity) {`
`97`		`- $this->getSpecificity();`
`98`		`- }`
`99`	`93`	`}`
`100`	`94`
`101`	`95`	`public function getSelector(): string`