[TASK] Use native types for all constructor parameters

oliverklee · oliverklee · commit 76170ec1eb09 · 2025-01-27T23:52:35.000+01:00
Part of #811
diff --git a/src/CSSList/AtRuleBlockList.php b/src/CSSList/AtRuleBlockList.php
@@ -22,12 +22,7 @@ class AtRuleBlockList extends CSSBlockList implements AtRule
      */
     private $sArgs;
 
-    /**
-     * @param string $type
-     * @param string $arguments
-     * @param int $lineNumber
-     */
-    public function __construct($type, $arguments = '', $lineNumber = 0)
+    public function __construct(string $type, string $arguments = '', int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
         $this->type = $type;
diff --git a/src/CSSList/CSSBlockList.php b/src/CSSList/CSSBlockList.php
@@ -20,10 +20,7 @@
  */
 abstract class CSSBlockList extends CSSList
 {
-    /**
-     * @param int $lineNumber
-     */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
     }
diff --git a/src/CSSList/CSSList.php b/src/CSSList/CSSList.php
@@ -48,10 +48,7 @@ abstract class CSSList implements Renderable, Commentable
      */
     protected $lineNumber;
 
-    /**
-     * @param int $lineNumber
-     */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         $this->comments = [];
         $this->aContents = [];
diff --git a/src/CSSList/Document.php b/src/CSSList/Document.php
@@ -18,10 +18,7 @@
  */
 class Document extends CSSBlockList
 {
-    /**
-     * @param int $lineNumber
-     */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
     }
diff --git a/src/CSSList/KeyFrame.php b/src/CSSList/KeyFrame.php
@@ -19,10 +19,7 @@ class KeyFrame extends CSSList implements AtRule
      */
     private $animationName;
 
-    /**
-     * @param int $lineNumber
-     */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
         $this->vendorKeyFrame = null;
diff --git a/src/Comment/Comment.php b/src/Comment/Comment.php
@@ -19,11 +19,7 @@ class Comment implements Renderable
      */
     protected $commentText;
 
-    /**
-     * @param string $commentText
-     * @param int $lineNumber
-     */
-    public function __construct($commentText = '', $lineNumber = 0)
+    public function __construct(string $commentText = '', int $lineNumber = 0)
     {
         $this->commentText = $commentText;
         $this->lineNumber = $lineNumber;
diff --git a/src/Parser.php b/src/Parser.php
@@ -20,10 +20,9 @@ class Parser
 
     /**
      * @param string $sText the complete CSS as text (i.e., usually the contents of a CSS file)
-     * @param Settings|null $oParserSettings
      * @param int $lineNumber the line number (starting from 1, not from 0)
      */
-    public function __construct($sText, ?Settings $oParserSettings = null, $lineNumber = 1)
+    public function __construct(string $sText, ?Settings $oParserSettings = null, int $lineNumber = 1)
     {
         if ($oParserSettings === null) {
             $oParserSettings = Settings::create();
diff --git a/src/Parsing/Anchor.php b/src/Parsing/Anchor.php
@@ -19,10 +19,7 @@ class Anchor
      */
     private $parserState;
 
-    /**
-     * @param int $iPosition
-     */
-    public function __construct($iPosition, ParserState $parserState)
+    public function __construct(int $iPosition, ParserState $parserState)
     {
         $this->iPosition = $iPosition;
         $this->parserState = $parserState;
diff --git a/src/Parsing/OutputException.php b/src/Parsing/OutputException.php
@@ -9,11 +9,7 @@
  */
 final class OutputException extends SourceException
 {
-    /**
-     * @param string $sMessage
-     * @param int $lineNumber
-     */
-    public function __construct($sMessage, $lineNumber = 0)
+    public function __construct(string $sMessage, int $lineNumber = 0)
     {
         parent::__construct($sMessage, $lineNumber);
     }
diff --git a/src/Parsing/ParserState.php b/src/Parsing/ParserState.php
@@ -58,9 +58,8 @@ class ParserState
 
     /**
      * @param string $sText the complete CSS as text (i.e., usually the contents of a CSS file)
-     * @param int $lineNumber
      */
-    public function __construct($sText, Settings $oParserSettings, $lineNumber = 1)
+    public function __construct(string $sText, Settings $oParserSettings, int $lineNumber = 1)
     {
         $this->oParserSettings = $oParserSettings;
         $this->sText = $sText;
diff --git a/src/Parsing/SourceException.php b/src/Parsing/SourceException.php
@@ -11,11 +11,7 @@ class SourceException extends \Exception
      */
     private $lineNumber;
 
-    /**
-     * @param string $sMessage
-     * @param int $lineNumber
-     */
-    public function __construct($sMessage, $lineNumber = 0)
+    public function __construct(string $sMessage, int $lineNumber = 0)
     {
         $this->lineNumber = $lineNumber;
         if ($lineNumber !== 0) {
diff --git a/src/Parsing/UnexpectedTokenException.php b/src/Parsing/UnexpectedTokenException.php
@@ -26,13 +26,7 @@ class UnexpectedTokenException extends SourceException
      */
     private $sMatchType;
 
-    /**
-     * @param string $sExpected
-     * @param string $sFound
-     * @param string $sMatchType
-     * @param int $lineNumber
-     */
-    public function __construct($sExpected, $sFound, $sMatchType = 'literal', $lineNumber = 0)
+    public function __construct(string $sExpected, string $sFound, string $sMatchType = 'literal', int $lineNumber = 0)
     {
         $this->sExpected = $sExpected;
         $this->sFound = $sFound;
diff --git a/src/Property/CSSNamespace.php b/src/Property/CSSNamespace.php
@@ -32,12 +32,7 @@ class CSSNamespace implements AtRule
      */
     protected $comments;
 
-    /**
-     * @param string $mUrl
-     * @param string|null $sPrefix
-     * @param int $lineNumber
-     */
-    public function __construct($mUrl, $sPrefix = null, $lineNumber = 0)
+    public function __construct(string $mUrl, ?string $sPrefix = null, int $lineNumber = 0)
     {
         $this->mUrl = $mUrl;
         $this->sPrefix = $sPrefix;
diff --git a/src/Property/Charset.php b/src/Property/Charset.php
@@ -33,11 +33,7 @@ class Charset implements AtRule
      */
     protected $comments;
 
-    /**
-     * @param CSSString $oCharset
-     * @param int $lineNumber
-     */
-    public function __construct(CSSString $oCharset, $lineNumber = 0)
+    public function __construct(CSSString $oCharset, int $lineNumber = 0)
     {
         $this->oCharset = $oCharset;
         $this->lineNumber = $lineNumber;
diff --git a/src/Property/Import.php b/src/Property/Import.php
@@ -33,12 +33,7 @@ class Import implements AtRule
      */
     protected $comments;
 
-    /**
-     * @param URL $oLocation
-     * @param string $sMediaQuery
-     * @param int $lineNumber
-     */
-    public function __construct(URL $oLocation, $sMediaQuery, $lineNumber = 0)
+    public function __construct(URL $oLocation, string $sMediaQuery, int $lineNumber = 0)
     {
         $this->oLocation = $oLocation;
         $this->sMediaQuery = $sMediaQuery;
diff --git a/src/Property/Selector.php b/src/Property/Selector.php
@@ -84,11 +84,7 @@ public static function isValid($sSelector)
         return \preg_match(static::SELECTOR_VALIDATION_RX, $sSelector);
     }
 
-    /**
-     * @param string $sSelector
-     * @param bool $bCalculateSpecificity
-     */
-    public function __construct($sSelector, $bCalculateSpecificity = false)
+    public function __construct(string $sSelector, bool $bCalculateSpecificity = false)
     {
         $this->setSelector($sSelector);
         if ($bCalculateSpecificity) {
diff --git a/src/Rule/Rule.php b/src/Rule/Rule.php
@@ -56,12 +56,7 @@ class Rule implements Renderable, Commentable
      */
     protected $comments;
 
-    /**
-     * @param string $sRule
-     * @param int $lineNumber
-     * @param int $iColNo
-     */
-    public function __construct($sRule, $lineNumber = 0, $iColNo = 0)
+    public function __construct(string $sRule, int $lineNumber = 0, int $iColNo = 0)
     {
         $this->sRule = $sRule;
         $this->mValue = null;
diff --git a/src/RuleSet/AtRuleSet.php b/src/RuleSet/AtRuleSet.php
@@ -25,12 +25,7 @@ class AtRuleSet extends RuleSet implements AtRule
      */
     private $sArgs;
 
-    /**
-     * @param string $sType
-     * @param string $sArgs
-     * @param int $lineNumber
-     */
-    public function __construct($sType, $sArgs = '', $lineNumber = 0)
+    public function __construct(string $sType, string $sArgs = '', int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
         $this->sType = $sType;
diff --git a/src/RuleSet/DeclarationBlock.php b/src/RuleSet/DeclarationBlock.php
@@ -29,10 +29,7 @@ class DeclarationBlock extends RuleSet
      */
     private $aSelectors;
 
-    /**
-     * @param int $lineNumber
-     */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
         $this->aSelectors = [];
diff --git a/src/RuleSet/RuleSet.php b/src/RuleSet/RuleSet.php
@@ -39,10 +39,7 @@ abstract class RuleSet implements Renderable, Commentable
      */
     protected $comments;
 
-    /**
-     * @param int $lineNumber
-     */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         $this->aRules = [];
         $this->lineNumber = $lineNumber;
diff --git a/src/Value/CSSFunction.php b/src/Value/CSSFunction.php
@@ -19,12 +19,9 @@ class CSSFunction extends ValueList
     protected $sName;
 
     /**
-     * @param string $sName
      * @param RuleValueList|array<array-key, Value|string> $aArguments
-     * @param string $sSeparator
-     * @param int $lineNumber
      */
-    public function __construct($sName, $aArguments, $sSeparator = ',', $lineNumber = 0)
+    public function __construct(string $sName, $aArguments, string $sSeparator = ',', int $lineNumber = 0)
     {
         if ($aArguments instanceof RuleValueList) {
             $sSeparator = $aArguments->getListSeparator();
diff --git a/src/Value/CSSString.php b/src/Value/CSSString.php
@@ -22,11 +22,7 @@ class CSSString extends PrimitiveValue
      */
     private $sString;
 
-    /**
-     * @param string $sString
-     * @param int $lineNumber
-     */
-    public function __construct($sString, $lineNumber = 0)
+    public function __construct(string $sString, int $lineNumber = 0)
     {
         $this->sString = $sString;
         parent::__construct($lineNumber);
diff --git a/src/Value/CalcRuleValueList.php b/src/Value/CalcRuleValueList.php
@@ -8,10 +8,7 @@
 
 class CalcRuleValueList extends RuleValueList
 {
-    /**
-     * @param int $lineNumber
-     */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         parent::__construct(',', $lineNumber);
     }
diff --git a/src/Value/Color.php b/src/Value/Color.php
@@ -17,9 +17,8 @@ class Color extends CSSFunction
 {
     /**
      * @param array<array-key, Value|string> $colorValues
-     * @param int $lineNumber
      */
-    public function __construct(array $colorValues, $lineNumber = 0)
+    public function __construct(array $colorValues, int $lineNumber = 0)
     {
         parent::__construct(\implode('', \array_keys($colorValues)), $colorValues, ',', $lineNumber);
     }
diff --git a/src/Value/LineName.php b/src/Value/LineName.php
@@ -13,9 +13,8 @@ class LineName extends ValueList
 {
     /**
      * @param array<int, Value|string> $aComponents
-     * @param int $lineNumber
      */
-    public function __construct(array $aComponents = [], $lineNumber = 0)
+    public function __construct(array $aComponents = [], int $lineNumber = 0)
     {
         parent::__construct($aComponents, ' ', $lineNumber);
     }
diff --git a/src/Value/PrimitiveValue.php b/src/Value/PrimitiveValue.php
@@ -6,10 +6,7 @@
 
 abstract class PrimitiveValue extends Value
 {
-    /**
-     * @param int $lineNumber
-     */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
     }
diff --git a/src/Value/RuleValueList.php b/src/Value/RuleValueList.php
@@ -11,11 +11,7 @@
  */
 class RuleValueList extends ValueList
 {
-    /**
-     * @param string $sSeparator
-     * @param int $lineNumber
-     */
-    public function __construct($sSeparator = ',', $lineNumber = 0)
+    public function __construct(string $sSeparator = ',', int $lineNumber = 0)
     {
         parent::__construct([], $sSeparator, $lineNumber);
     }
diff --git a/src/Value/Size.php b/src/Value/Size.php
@@ -69,11 +69,8 @@ class Size extends PrimitiveValue
 
     /**
      * @param float|int|string $fSize
-     * @param string|null $sUnit
-     * @param bool $bIsColorComponent
-     * @param int $lineNumber
      */
-    public function __construct($fSize, $sUnit = null, $bIsColorComponent = false, $lineNumber = 0)
+    public function __construct($fSize, ?string $sUnit = null, bool $bIsColorComponent = false, int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
         $this->fSize = (float) $fSize;
diff --git a/src/Value/URL.php b/src/Value/URL.php
@@ -20,10 +20,7 @@ class URL extends PrimitiveValue
      */
     private $oURL;
 
-    /**
-     * @param int $lineNumber
-     */
-    public function __construct(CSSString $oURL, $lineNumber = 0)
+    public function __construct(CSSString $oURL, int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
         $this->oURL = $oURL;
diff --git a/src/Value/Value.php b/src/Value/Value.php
@@ -21,10 +21,7 @@ abstract class Value implements Renderable
      */
     protected $lineNumber;
 
-    /**
-     * @param int $lineNumber
-     */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         $this->lineNumber = $lineNumber;
     }
diff --git a/src/Value/ValueList.php b/src/Value/ValueList.php
@@ -26,10 +26,8 @@ abstract class ValueList extends Value
 
     /**
      * @param array<array-key, Value|string>|Value|string $aComponents
-     * @param string $sSeparator
-     * @param int $lineNumber
      */
-    public function __construct($aComponents = [], $sSeparator = ',', $lineNumber = 0)
+    public function __construct($aComponents = [], string $sSeparator = ',', int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
         if (!\is_array($aComponents)) {

Original file line number	Diff line number	Diff line change
`@@ -20,10 +20,7 @@`
`20`	`20`	`*/`
`21`	`21`	`abstract class CSSBlockList extends CSSList`
`22`	`22`	`{`
`23`		`- /**`
`24`		`- * @param int $lineNumber`
`25`		`- */`
`26`		`- public function __construct($lineNumber = 0)`
	`23`	`+ public function __construct(int $lineNumber = 0)`
`27`	`24`	`{`
`28`	`25`	`parent::__construct($lineNumber);`
`29`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,10 +18,7 @@`
`18`	`18`	`*/`
`19`	`19`	`class Document extends CSSBlockList`
`20`	`20`	`{`
`21`		`- /**`
`22`		`- * @param int $lineNumber`
`23`		`- */`
`24`		`- public function __construct($lineNumber = 0)`
	`21`	`+ public function __construct(int $lineNumber = 0)`
`25`	`22`	`{`
`26`	`23`	`parent::__construct($lineNumber);`
`27`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,11 +9,7 @@`
`9`	`9`	`*/`
`10`	`10`	`final class OutputException extends SourceException`
`11`	`11`	`{`
`12`		`- /**`
`13`		`- * @param string $sMessage`
`14`		`- * @param int $lineNumber`
`15`		`- */`
`16`		`- public function __construct($sMessage, $lineNumber = 0)`
	`12`	`+ public function __construct(string $sMessage, int $lineNumber = 0)`
`17`	`13`	`{`
`18`	`14`	`parent::__construct($sMessage, $lineNumber);`
`19`	`15`	`}`