[CLEANUP] Avoid Hungarian notation for sizeUnit (#1095)

oliverklee · web-flow · commit b24c4f8a5542 · 2025-03-06T14:18:11.000Z
Part of #756
diff --git a/src/Value/Size.php b/src/Value/Size.php
@@ -131,12 +131,13 @@ private static function getSizeUnits()
     {
         if (!\is_array(self::$SIZE_UNITS)) {
             self::$SIZE_UNITS = [];
-            foreach (\array_merge(self::ABSOLUTE_SIZE_UNITS, self::RELATIVE_SIZE_UNITS, self::NON_SIZE_UNITS) as $val) {
-                $tokenLength = \strlen($val);
+            $sizeUnits = \array_merge(self::ABSOLUTE_SIZE_UNITS, self::RELATIVE_SIZE_UNITS, self::NON_SIZE_UNITS);
+            foreach ($sizeUnits as $sizeUnit) {
+                $tokenLength = \strlen($sizeUnit);
                 if (!isset(self::$SIZE_UNITS[$tokenLength])) {
                     self::$SIZE_UNITS[$tokenLength] = [];
                 }
-                self::$SIZE_UNITS[$tokenLength][\strtolower($val)] = $val;
+                self::$SIZE_UNITS[$tokenLength][\strtolower($sizeUnit)] = $sizeUnit;
             }
 
             \krsort(self::$SIZE_UNITS, SORT_NUMERIC);

Original file line number	Diff line number	Diff line change
`@@ -131,12 +131,13 @@ private static function getSizeUnits()`
`131`	`131`	`{`
`132`	`132`	`if (!\is_array(self::$SIZE_UNITS)) {`
`133`	`133`	`self::$SIZE_UNITS = [];`
`134`		`- foreach (\array_merge(self::ABSOLUTE_SIZE_UNITS, self::RELATIVE_SIZE_UNITS, self::NON_SIZE_UNITS) as $val) {`
`135`		`- $tokenLength = \strlen($val);`
	`134`	`+ $sizeUnits = \array_merge(self::ABSOLUTE_SIZE_UNITS, self::RELATIVE_SIZE_UNITS, self::NON_SIZE_UNITS);`
	`135`	`+ foreach ($sizeUnits as $sizeUnit) {`
	`136`	`+ $tokenLength = \strlen($sizeUnit);`
`136`	`137`	`if (!isset(self::$SIZE_UNITS[$tokenLength])) {`
`137`	`138`	`self::$SIZE_UNITS[$tokenLength] = [];`
`138`	`139`	`}`
`139`		`- self::$SIZE_UNITS[$tokenLength][\strtolower($val)] = $val;`
	`140`	`+ self::$SIZE_UNITS[$tokenLength][\strtolower($sizeUnit)] = $sizeUnit;`
`140`	`141`	`}`
`141`	`142`
`142`	`143`	`\krsort(self::$SIZE_UNITS, SORT_NUMERIC);`