[TASK] Drop greedy calculation of selector specificity

This constructor parameter is not used, and having the
specificity calculation always done lazily is not a problem.

Author: oliverklee

CHANGELOG.md

@@ -38,6 +38,7 @@ Please also have a look at our
 
 ### Removed
 
+- Drop greedy calculation of selector specificity (#1021)
 - Remove `OutputFormat::level()` (#874)
 - Remove expansion of shorthand properties (#838)
 - Remove `Parser::setCharset/getCharset` (#808)

src/Property/Selector.php

@@ -86,14 +86,10 @@ public static function isValid($selector)
 
     /**
      * @param string $selector
-     * @param bool $calculateSpecificity @deprecated since V8.8.0, will be removed in V9.0.0
      */
-    public function __construct($selector, $calculateSpecificity = false)
+    public function __construct($selector)
     {
         $this->setSelector($selector);
-        if ($calculateSpecificity) {
-            $this->getSpecificity();
-        }
     }
 
     /**

tests/ParserTest.php

@@ -270,26 +270,28 @@ public function specificity(): void
                     self::fail('specificity: untested selector ' . $selector->getSelector());
             }
         }
-        self::assertEquals([new Selector('#test .help', true)], $document->getSelectorsBySpecificity('> 100'));
+        $matchingSelectors1 = $document->getSelectorsBySpecificity('> 100');
+        self::assertCount(1, $matchingSelectors1);
+        self::assertSame('#test .help', $matchingSelectors1[0]->getSelector());
         self::assertEquals(
-            [new Selector('#test .help', true), new Selector('#file', true)],
+            [new Selector('#test .help'), new Selector('#file')],
             $document->getSelectorsBySpecificity('>= 100')
         );
-        self::assertEquals([new Selector('#file', true)], $document->getSelectorsBySpecificity('=== 100'));
-        self::assertEquals([new Selector('#file', true)], $document->getSelectorsBySpecificity('== 100'));
+        self::assertEquals([new Selector('#file')], $document->getSelectorsBySpecificity('=== 100'));
+        self::assertEquals([new Selector('#file')], $document->getSelectorsBySpecificity('== 100'));
         self::assertEquals([
-            new Selector('#file', true),
-            new Selector('.help:hover', true),
-            new Selector('li.green', true),
-            new Selector('ol li::before', true),
+            new Selector('#file'),
+            new Selector('.help:hover'),
+            new Selector('li.green'),
+            new Selector('ol li::before'),
         ], $document->getSelectorsBySpecificity('<= 100'));
         self::assertEquals([
-            new Selector('.help:hover', true),
-            new Selector('li.green', true),
-            new Selector('ol li::before', true),
+            new Selector('.help:hover'),
+            new Selector('li.green'),
+            new Selector('ol li::before'),
         ], $document->getSelectorsBySpecificity('< 100'));
-        self::assertEquals([new Selector('li.green', true)], $document->getSelectorsBySpecificity('11'));
-        self::assertEquals([new Selector('ol li::before', true)], $document->getSelectorsBySpecificity('3'));
+        self::assertEquals([new Selector('li.green')], $document->getSelectorsBySpecificity('11'));
+        self::assertEquals([new Selector('ol li::before')], $document->getSelectorsBySpecificity('3'));
     }
 
     /**