[TASK] Mark Selector::isValid() as @internal
#1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
task/internal/valid-selector
branch
from
6464ee5 to
c615a95
Compare
JakeQZ
approved these changes
Feb 28, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
It does indeed seem to be used internally, right before constructing a Selector - rather suggesting that the Selector constructor should be making this check itself instead (beyond the scope of this PR).
oliverklee
added a commit
that referenced
this pull request
Feb 28, 2025
This is the V8.x backport of #1037.
oliverklee
added a commit
that referenced
this pull request
Feb 28, 2025
This is the V8.x backport of #1037.
Collaborator
Added #1041 to capture this. |
JakeQZ
pushed a commit
that referenced
this pull request
Mar 1, 2025
This is the V8.x backport of #1037.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.