Skip to content

[CLEANUP] Improve readability of instanceof calls #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

[CLEANUP] Improve readability of instanceof calls #856

merged 1 commit into from
Jan 31, 2025

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Jan 31, 2025 •
edited
Loading

  • use paranthesis for negated instanceof calls
  • use assertInstanceOf in the tests

@oliverklee oliverklee self-assigned this Jan 31, 2025
@oliverklee
[CLEANUP] Improve readability of instanceof calls
b53c79a 
- use paranthesis for negated `instanceof` calls
- use `assertInstanceOf` in the tests
@coveralls
Copy link

coveralls commented Jan 31, 2025 •
edited
Loading

Coverage Status

coverage: 45.068%. remained the same
when pulling b53c79a on cleanup/instanceof
into 24e69d4 on main.

@JakeQZ JakeQZ merged commit 400f3fd into main Jan 31, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/instanceof branch January 31, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels

cleanup

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverklee @coveralls @JakeQZ