[BUGFIX] Fix return type annotation of Value::isSize()
#892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
requested changes
Feb 9, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
I think the comment can just be changed to use the word "Returns" instead of @return.
| /** | ||
| * Returns whether the number stored in this Size really represents a size (as in a length of something on screen). | ||
| * | ||
| * @return false if the unit an angle, a duration, a frequency or the number is a component in a Color object. |
Collaborator
There was a problem hiding this comment.
I think just change this comment to not involve a type annotation - i.e. "Returns false if the unit [is]..." (and add the missing "is") - so the meaning is retained.
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
|
|
||
| - Fix return type annotation of `Value::isSize()` (#892) |
Collaborator
There was a problem hiding this comment.
Not sure if we're just changing a DocBlock comment this warrants a changelog entry.
JakeQZ
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.