Skip to content

[BUGFIX] Fix return type annotation of Value::isSize() #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2025
Merged

[BUGFIX] Fix return type annotation of Value::isSize() #892

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4de879f
[BUGFIX] Fix return type annotation of `Value::isSize()`
oliverklee Feb 9, 2025
2f7e23e
Changes as suggested in code review
oliverklee Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ Please also have a look at our

### Fixed

- Fix return type annotation of `Value::isSize()` (#892)
Copy link
Collaborator

@JakeQZ JakeQZ Feb 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we're just changing a DocBlock comment this warrants a changelog entry.

- Don't render `rgb` colors with percentage values using hex notation (#803)
- Parse `@font-face` `src` property as comma-delimited list (#790)

Expand Down
2 changes: 1 addition & 1 deletion src/Value/Size.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public function isColorComponent()
/**
* Returns whether the number stored in this Size really represents a size (as in a length of something on screen).
*
* @return false if the unit an angle, a duration, a frequency or the number is a component in a Color object.
Copy link
Collaborator

@JakeQZ JakeQZ Feb 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just change this comment to not involve a type annotation - i.e. "Returns false if the unit [is]..." (and add the missing "is") - so the meaning is retained.

* @return bool whether the unit is an angle, a duration, a frequency or the number is a component in a Color object
*/
public function isSize(): bool
{
Expand Down