Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
139 changes: 139 additions & 0 deletions tests/Unit/OutputFormatTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,16 @@ public function createCompactReturnsInstanceWithSpaceAfterSelectorSeparatorSetTo
self::assertSame('', $newInstance->getSpaceAfterSelectorSeparator());
}

/**
* @test
*/
public function createCompactReturnsInstanceWithSpaceAfterListArgumentSeparatorsSetToEmptyArray(): void
{
$newInstance = OutputFormat::createCompact();

self::assertSame([], $newInstance->getSpaceAfterListArgumentSeparators());
}

/**
* @test
*/
Expand All @@ -1025,4 +1035,133 @@ public function createCompactReturnsInstanceWithRenderCommentsDisabled(): void

self::assertFalse($newInstance->getRenderComments());
}

/**
* @test
*/
public function createPrettyReturnsNewOutputFormatInstance(): void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "New" is redundant in the test method name, but it's consistent with createCompactReturnsNewOutputFormatInstance, which I signed off 🤷

{
self::assertInstanceOf(OutputFormat::class, OutputFormat::createPretty());
}

/**
* @test
*/
public function createPrettyCalledTwoTimesReturnsDifferentInstances(): void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking (and agreeing) "TwoTimes" is better than "Twice" for non-native-English speaking coders.

{
$firstCallResult = OutputFormat::createPretty();
$secondCallResult = OutputFormat::createPretty();

self::assertNotSame($firstCallResult, $secondCallResult);
}

/**
* @test
*/
public function createPrettyReturnsInstanceWithSpaceBeforeRulesSetToNewline(): void
{
$newInstance = OutputFormat::createPretty();

self::assertSame("\n", $newInstance->getSpaceBeforeRules());
}

/**
* @test
*/
public function createPrettyReturnsInstanceWithSpaceBetweenRulesSetToNewline(): void
{
$newInstance = OutputFormat::createPretty();

self::assertSame("\n", $newInstance->getSpaceBetweenRules());
}

/**
* @test
*/
public function createPrettyReturnsInstanceWithSpaceAfterRulesSetToNewline(): void
{
$newInstance = OutputFormat::createPretty();

self::assertSame("\n", $newInstance->getSpaceAfterRules());
}

/**
* @test
*/
public function createPrettyReturnsInstanceWithSpaceBeforeBlocksSetToNewline(): void
{
$newInstance = OutputFormat::createPretty();

self::assertSame("\n", $newInstance->getSpaceBeforeBlocks());
}

/**
* @test
*/
public function createPrettyReturnsInstanceWithSpaceBetweenBlocksSetToTwoNewlines(): void
{
$newInstance = OutputFormat::createPretty();

self::assertSame("\n\n", $newInstance->getSpaceBetweenBlocks());
}

/**
* @test
*/
public function createPrettyReturnsInstanceWithSpaceAfterBlocksSetToNewline(): void
{
$newInstance = OutputFormat::createPretty();

self::assertSame("\n", $newInstance->getSpaceAfterBlocks());
}

/**
* @test
*/
public function createPrettyReturnsInstanceWithSpaceAfterRuleNameSetSpace(): void
{
$newInstance = OutputFormat::createPretty();

self::assertSame(' ', $newInstance->getSpaceAfterRuleName());
}

/**
* @test
*/
public function createPrettyReturnsInstanceWithSpaceBeforeOpeningBraceSetToSpace(): void
{
$newInstance = OutputFormat::createPretty();

self::assertSame(' ', $newInstance->getSpaceBeforeOpeningBrace());
}

/**
* @test
*/
public function createPrettyReturnsInstanceWithSpaceAfterSelectorSeparatorSetToSpace(): void
{
$newInstance = OutputFormat::createPretty();

self::assertSame(' ', $newInstance->getSpaceAfterSelectorSeparator());
}

/**
* @test
*/
public function createPrettyReturnsInstanceWithSpaceAfterListArgumentSeparatorsSetToSpaceForComma(): void
{
$newInstance = OutputFormat::createPretty();

self::assertSame([',' => ' '], $newInstance->getSpaceAfterListArgumentSeparators());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just test that the key , has the value {space} - instead of the whole array?

Copy link
Collaborator

@JakeQZ JakeQZ Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe the test method should be renamed to indicate it's checking the whole array by adding On;y at the end of its name.

}

/**
* @test
*/
public function createPrettyReturnsInstanceWithRenderCommentsEnabled(): void
{
$newInstance = OutputFormat::createPretty();

self::assertTrue($newInstance->getRenderComments());
}
}