Skip to content

[TASK] Mark many parsing-related methods as @internal #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

[TASK] Mark many parsing-related methods as @internal #908

merged 1 commit into from
Feb 13, 2025

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Feb 11, 2025

The only parsing method that is expected to be called from outside of this library is Parser::parse().

@oliverklee oliverklee self-assigned this Feb 11, 2025
@oliverklee
[TASK] Mark many parsing-related methods as @internal
7d7b5da 
The only parsing method that is expected to be called from outside
of this library is `Parser::parse()`.
@oliverklee oliverklee force-pushed the task/internal-parsing branch from 4e6f992 to 7d7b5da Compare February 11, 2025 19:13
JakeQZ
JakeQZ approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I wou;dn't expect anyone to be attempting to parse the constructs in isolation. And not even Document::parse() needs to be part of the public API.

@JakeQZ JakeQZ merged commit 537f5e8 into main Feb 13, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/internal-parsing branch February 13, 2025 02:18
@coveralls
Copy link

coveralls commented Feb 13, 2025

Coverage Status

coverage: 49.156%. first build
when pulling 4e6f992 on task/internal-parsing
into b3e83b8 on main.

oliverklee added a commit that referenced this pull request Feb 13, 2025
@oliverklee
[TASK] Mark many parsing-related methods as @internal
aa02ab1 
The only parsing method that is expected to be called from outside
of this library is `Parser::parse()`.

This is the V8.x backport of #908.
oliverklee added a commit that referenced this pull request Feb 13, 2025
@oliverklee
[TASK] Mark many parsing-related methods as @internal
cc872ed 
The only parsing method that is expected to be called from outside
of this library is `Parser::parse()`.

This is the V8.x backport of #908.
@oliverklee oliverklee mentioned this pull request Feb 13, 2025
Merged
JakeQZ pushed a commit that referenced this pull request Feb 13, 2025
@oliverklee
[TASK] Mark many parsing-related methods as @internal (#913)
769e1df 
The only parsing method that is expected to be called from outside
of this library is `Parser::parse()`.

This is the V8.x backport of #908.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels

None yet

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverklee @coveralls @JakeQZ