[TASK] Make the tests more strict #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
approved these changes
Feb 14, 2025
| $contentRules = $ruleSet->getRules('content'); | ||
| $firstContentRuleAsString = $contentRules[0]->getValue()->__toString(); | ||
| if ($selector == '.test-1') { | ||
| if ($selector === '.test-1') { |
Collaborator
There was a problem hiding this comment.
It won't make any difference comparing with strings other than "0", but better to use === anyway.
Comment on lines
+1242
to
+1243
| self::assertInstanceOf(URL::class, $urlRule->getValue()); | ||
| self::assertInstanceOf(CalcFunction::class, $calcRule->getValue()); |
Collaborator
There was a problem hiding this comment.
Maybe assertInstanceOf wasn't around at the time these tests were implemented. Good improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.