Skip to content

[CLEANUP] Avoid Hungarian notation for position #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025
Merged

[CLEANUP] Avoid Hungarian notation for position #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Parsing/Anchor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,24 @@ class Anchor
/**
* @var int
*/
private $iPosition;
private $position;

/**
* @var ParserState
*/
private $parserState;

/**
* @param int $iPosition
* @param int $position
*/
public function __construct($iPosition, ParserState $parserState)
public function __construct($position, ParserState $parserState)
{
$this->iPosition = $iPosition;
$this->position = $position;
$this->parserState = $parserState;
}

public function backtrack(): void
{
$this->parserState->setPosition($this->iPosition);
$this->parserState->setPosition($this->position);
}
}
6 changes: 3 additions & 3 deletions src/Parsing/ParserState.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,11 @@ public function anchor(): Anchor
}

/**
* @param int $iPosition
* @param int $position
*/
public function setPosition($iPosition): void
public function setPosition($position): void
{
$this->iCurrentPosition = $iPosition;
$this->iCurrentPosition = $position;
}

/**
Expand Down
6 changes: 3 additions & 3 deletions src/RuleSet/RuleSet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,12 @@ public function addRule(Rule $rule, ?Rule $oSibling = null): void
$this->aRules[$sRule] = [];
}

$iPosition = \count($this->aRules[$sRule]);
$position = \count($this->aRules[$sRule]);

if ($oSibling !== null) {
$iSiblingPos = \array_search($oSibling, $this->aRules[$sRule], true);
if ($iSiblingPos !== false) {
$iPosition = $iSiblingPos;
$position = $iSiblingPos;
$rule->setPosition($oSibling->getLineNo(), $oSibling->getColNo() - 1);
}
}
Expand All @@ -127,7 +127,7 @@ public function addRule(Rule $rule, ?Rule $oSibling = null): void
}
}

\array_splice($this->aRules[$sRule], $iPosition, 0, [$rule]);
\array_splice($this->aRules[$sRule], $position, 0, [$rule]);
}

/**
Expand Down