Skip to content

[CLEANUP] Use a per-test subject for DocumentTest #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

[CLEANUP] Use a per-test subject for DocumentTest #963

merged 1 commit into from
Feb 20, 2025

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Feb 20, 2025

No description provided.

@oliverklee oliverklee requested a review from JakeQZ February 20, 2025 10:06
@oliverklee oliverklee self-assigned this Feb 20, 2025
@oliverklee oliverklee mentioned this pull request Feb 20, 2025
Merged
@coveralls
Copy link

coveralls commented Feb 20, 2025 •
edited
Loading

Coverage Status

coverage: 51.654%. remained the same
when pulling 5457d42 on cleanup/tests-setup
into 3a05e1f on main.

JakeQZ
JakeQZ approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it does indeed make it much clearer to see what's going on in each test :)

And there's barely any more code involved by replacing $this->subject with new Document().

@JakeQZ JakeQZ merged commit d7d9128 into main Feb 20, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/tests-setup branch February 20, 2025 10:18
oliverklee added a commit that referenced this pull request Feb 20, 2025
@oliverklee
[TASK] Use a per-test subject in KeyFrameTest
1a2eab9 
Similar to #963.
oliverklee added a commit that referenced this pull request Feb 20, 2025
@oliverklee
[TASK] Extend and streamline KeyFrameTest
f03fa14 
- use a per-test subject similar to #963
- add a missing `@covers` annotation for the parent class
- add tests for the line number

Part of #757
@oliverklee oliverklee mentioned this pull request Feb 20, 2025
Merged
JakeQZ pushed a commit that referenced this pull request Feb 20, 2025
@oliverklee
[TASK] Extend and streamline KeyFrameTest (#971)
ce0a049 
- use a per-test subject similar to #963
- add a missing `@covers` annotation for the parent class
- add tests for the line number

Part of #757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels

None yet

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverklee @coveralls @JakeQZ