[CLEANUP] Avoid Hungarian notation for start(Position)
#977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
requested changes
Feb 24, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
I think $offset would be better throughout as a variable name.
src/Parsing/ParserState.php
Outdated
| * @param int $length | ||
| */ | ||
| private function substr($iStart, $length): string | ||
| private function substr($start, $length): string |
Collaborator
There was a problem hiding this comment.
The equivalant PHP function has this parameter as $offset, which I think is better.
src/Value/Value.php
Outdated
| for ($iStartPosition = 0; $iStartPosition < $iStackLength; ++$iStartPosition) { | ||
| if ($iStartPosition === ($iStackLength - 1) || $sDelimiter !== $aStack[$iStartPosition + 1]) { | ||
| $aNewStack[] = $aStack[$iStartPosition]; | ||
| for ($startPosition = 0; $startPosition < $iStackLength; ++$startPosition) { |
Collaborator
There was a problem hiding this comment.
Perhaps $offset would be a better name here too - particularly as it is changed during loop iteration to lose its original "start" meaning.
oliverklee
force-pushed
the
cleanup/hungarian/start
branch
from
97996b5 to
ed47f1e
Compare
JakeQZ
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #756