[CLEANUP] Avoid Hungarian notation in ParserState
#980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
requested changes
Feb 24, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
Could we improve on the naming of the $amount parameter, as we are renaming it?
src/Parsing/ParserState.php
Outdated
|
|
||
| /** | ||
| * @param int $iAmount | ||
| * @param int $amount |
Collaborator
There was a problem hiding this comment.
We could possibly improve this parameter name while renaming it. Perhaps $characterCount or $numberOfCharacters.
| /** | ||
| * @param string $string | ||
| * @param string $sNeedle | ||
| * @param string $haystack |
Collaborator
There was a problem hiding this comment.
Good rename to match the PHP docs.
oliverklee
force-pushed
the
cleanup/hungarian/parser-state
branch
from
38fd14b to
734366b
Compare
JakeQZ
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #756