[TASK] Add tests for Document::getAllRuleSets()
#991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
task/tests/get-all-rulesets
branch
from
52bd86e to
d097e0b
Compare
JakeQZ
reviewed
Feb 25, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
The tests look fine. I've suggested improvements for some of the test method names, where I found them difficult to understand (and, equally, difficult to rewrite).
oliverklee
force-pushed
the
task/tests/get-all-rulesets
branch
from
d097e0b to
41a4348
Compare
oliverklee
force-pushed
the
task/tests/get-all-rulesets
branch
from
41a4348 to
a7747f4
Compare
Co-authored-by: JakeQZ <[email protected]>
Co-authored-by: JakeQZ <[email protected]>
Co-authored-by: JakeQZ <[email protected]>
Co-authored-by: JakeQZ <[email protected]>
Co-authored-by: JakeQZ <[email protected]>
JakeQZ
approved these changes
Feb 26, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
Trying to test that RuleSets are being set does create some awkwardness re test method names. It would much easier if they were called RuleCollections. Or we used German - the two meanings of the English word 'set' don't seem to have any correlation.
I think we've done the best we reasonably can :)
Collaborator
Author
|
Yes, naming is one of the two hard things in computer science … 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #757