@@ -5,14 +5,12 @@ clean-up to Emogrifier are more than welcome.
55
66When you contribute, please take the following things into account:
77
8-
98## Contributor Code of Conduct
109
1110Please note that this project is released with a
1211[ Contributor Code of Conduct] ( ../CODE_OF_CONDUCT.md ) . By participating in this
1312project, you agree to abide by its terms.
1413
15-
1614## General workflow
1715
1816This is the workflow for contributing changes to Emogrifier:
@@ -37,7 +35,6 @@ This is the workflow for contributing changes to Emogrifier:
3735 from @oliverklee .
383611 . Together with him, polish your changes until they are ready to be merged.
3937
40-
4138## About code reviews
4239
4340After you have submitted a pull request, the Emogrifier team will review your
@@ -55,7 +52,6 @@ the Emogrifier project or would like to get feedback on the best architecture
5552for your ideas, we propose you open a ticket first and discuss your ideas there
5653first before investing a lot of time in writing code.
5754
58-
5955## Install the development dependencies
6056
6157To install the development dependencies (PHPUnit and PHP_CodeSniffer), please
@@ -71,7 +67,6 @@ require PHP 7.0 or later. The second command installs the PHP_CodeSniffer
7167dependencies and should be omitted if specifically testing against an earlier
7268version of PHP, however you will not be able to run the static code analysis.
7369
74-
7570## Unit-test your changes
7671
7772Please cover all changes with unit tests and make sure that your code does not
@@ -84,7 +79,6 @@ To run the existing PHPUnit tests, run this command:
8479composer ci:tests:unit
8580```
8681
87-
8882## Coding Style
8983
9084Please use the same coding style (PSR-2) as the rest of the code. Indentation
@@ -110,7 +104,6 @@ You can autoformat your code using the following command:
110104composer php:fix
111105```
112106
113-
114107## Git commits
115108
116109Commit message should have a <= 50 character summary, optionally followed by a
@@ -122,13 +115,11 @@ Also, please prefix the subject line of the commit message with either
122115[ FEATURE] , [ TASK] , [ BUGFIX] OR [ CLEANUP] . This makes it faster to see what
123116a commit is about.
124117
125-
126118## Creating pull requests (PRs)
127119
128120When you create a pull request, please
129121[ make your PR editable] ( https://github.com/blog/2247-improving-collaboration-with-forks ) .
130122
131-
132123## Rebasing
133124
134125If other PRs have been merged during the time between your initial PR creation
0 commit comments