Skip to content

Commit 4761579

Browse files
committed
Revert "src: simplify format in node_file.cc"
This reverts commit 673f49a. This change is breaking gulp on v14.x. Reverting so we can reland in a way that doesn't break stuff Refs: nodejs#33660 Refs: nodejs#34371
1 parent da95dd7 commit 4761579

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/node_file.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -488,9 +488,9 @@ int FileHandle::ReadStart() {
488488

489489
// Push the read wrap back to the freelist, or let it be destroyed
490490
// once we’re exiting the current scope.
491-
constexpr size_t kWantedFreelistFill = 100;
491+
constexpr size_t wanted_freelist_fill = 100;
492492
auto& freelist = handle->binding_data_->file_handle_read_wrap_freelist;
493-
if (freelist.size() < kWantedFreelistFill) {
493+
if (freelist.size() < wanted_freelist_fill) {
494494
read_wrap->Reset();
495495
freelist.emplace_back(std::move(read_wrap));
496496
}
@@ -758,7 +758,7 @@ void AfterScanDir(uv_fs_t* req) {
758758
int r;
759759
std::vector<Local<Value>> name_v;
760760

761-
for (;;) {
761+
for (int i = 0; ; i++) {
762762
uv_dirent_t ent;
763763

764764
r = uv_fs_scandir_next(req, &ent);
@@ -799,7 +799,7 @@ void AfterScanDirWithTypes(uv_fs_t* req) {
799799
std::vector<Local<Value>> name_v;
800800
std::vector<Local<Value>> type_v;
801801

802-
for (;;) {
802+
for (int i = 0; ; i++) {
803803
uv_dirent_t ent;
804804

805805
r = uv_fs_scandir_next(req, &ent);

0 commit comments

Comments
 (0)