Commit 2b532bc
authored
[dapp-kit] prefix all CSS with [data-dapp-kit] to prevent styles from getting overridden (#14210)
## Description
While migrating SuiFrens over to dapp-kit, I noticed the styles coming
from dapp-kit were getting overridden due to having low specificity. We
can prefix all styles with `[data-dapp-kit]` to up the specificity and
solve the issue, which is inline with what other UI kit libraries seem
to do.
As part of this, I'm upgrading postcss because the overrides specifier
only works on the first clean `pnpm install` and I couldn't get a clean
lockfile even on main 🤷🏼
Before:
<img width="438" alt="image"
src="https://github.com/MystenLabs/sui/assets/7453188/3c8a801c-e193-49ba-9585-836105d92740">
After:
<img width="1722" alt="image"
src="https://github.com/MystenLabs/sui/assets/7453188/c8486aa2-28b5-4670-a6f1-0bf663a6ab1f">
## Test Plan
- Manual testing
- CI
---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.
### Type of Change (Check all that apply)
- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration
### Release notes1 parent 3480c70 commit 2b532bc
File tree
11 files changed
+126
-92
lines changed- .changeset
- apps
- core
- explorer
- wallet
- dapps
- kiosk
- multisig-toolkit
- sponsored-transactions
- sdk
- build-scripts
- src
- dapp-kit/src/components/styling
11 files changed
+126
-92
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
| 106 | + | |
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
0 commit comments