Restore the environment variable to enable write sync (#24974)

Default fsync to false, but allow enabling it with an env var.

Deployment

Author: mwtian

crates/typed-store/src/rocks/mod.rs

@@ -39,7 +39,7 @@ use std::{
     marker::PhantomData,
     ops::RangeBounds,
     path::{Path, PathBuf},
-    sync::Arc,
+    sync::{Arc, OnceLock},
     time::Duration,
 };
 use std::{collections::HashSet, ffi::CStr};
@@ -54,6 +54,13 @@ use tracing::{debug, error, instrument, warn};
 const ROCKSDB_PROPERTY_TOTAL_BLOB_FILES_SIZE: &CStr =
     unsafe { CStr::from_bytes_with_nul_unchecked("rocksdb.total-blob-file-size\0".as_bytes()) };
 
+static WRITE_SYNC_ENABLED: OnceLock<bool> = OnceLock::new();
+
+fn write_sync_enabled() -> bool {
+    *WRITE_SYNC_ENABLED
+        .get_or_init(|| std::env::var("SUI_DB_SYNC_TO_DISK").is_ok_and(|v| v == "1" || v == "true"))
+}
+
 #[cfg(test)]
 mod tests;
 
@@ -1201,7 +1208,11 @@ impl DBBatch {
     #[instrument(level = "trace", skip_all, err)]
     pub fn write(self) -> Result<(), TypedStoreError> {
         let mut write_options = rocksdb::WriteOptions::default();
-        write_options.set_sync(true);
+
+        if write_sync_enabled() {
+            write_options.set_sync(true);
+        }
+
         self.write_opt(write_options)
     }
 

crates/typed-store/src/rocks/options.rs

@@ -38,8 +38,6 @@ pub struct ReadWriteOptions {
     /// When set, debug log the hash of the key and value bytes when inserting to
     /// this table.
     pub log_value_hash: bool,
-    /// Whether to sync to disk on every write.
-    pub sync_writes: bool,
 }
 
 impl ReadWriteOptions {
@@ -65,7 +63,6 @@ impl Default for ReadWriteOptions {
         Self {
             ignore_range_deletions: true,
             log_value_hash: false,
-            sync_writes: false,
         }
     }
 }