Split write API tests into dedicated test file with correctness checks

Move executeTransactionBlock and dryRunTransactionBlock tests from
jsonrpc_fn_delegation_tests.rs into a new jsonrpc_write_api_tests.rs.
The delegation test file now only tests governance APIs (getStakes,
getStakesByIds, getValidatorsApy) and no longer needs a gRPC URL.

The new write tests verify conversion correctness: sender identity in
transaction input, exact balance change amounts for sender/recipient,
effects status and gas costs, object change types, and consistency
between dry run and execute results.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: emmazzz

crates/sui-indexer-alt-e2e-tests/tests/jsonrpc_fn_delegation_tests.rs

@@ -40,7 +40,7 @@ struct FnDelegationTestCluster {
 }
 
 impl FnDelegationTestCluster {
-    /// Creates a new test cluster with an RPC with transaction execution enabled.
+    /// Creates a new test cluster with an RPC with delegation governance enabled.
     async fn new() -> anyhow::Result<Self> {
         let onchain_cluster = TestClusterBuilder::new()
             .with_num_validators(1)
@@ -56,7 +56,6 @@ impl FnDelegationTestCluster {
             .await;
 
         let fullnode_rpc_url = Url::parse(onchain_cluster.rpc_url())?;
-        let fullnode_grpc_url = onchain_cluster.rpc_url().to_string();
 
         let rpc_listen_address =
             SocketAddr::new(IpAddr::V4(Ipv4Addr::LOCALHOST), get_available_port());
@@ -80,7 +79,7 @@ impl FnDelegationTestCluster {
             rpc_args,
             NodeArgs {
                 fullnode_rpc_url: Some(fullnode_rpc_url),
-                fullnode_grpc_url: Some(fullnode_grpc_url),
+                fullnode_grpc_url: None,
             },
             SystemPackageTaskArgs::default(),
             RpcConfig::default(),
@@ -97,43 +96,6 @@ impl FnDelegationTestCluster {
         })
     }
 
-    /// Builds a simple transaction and returns the digest, tx bytes, and sigs to be used for testing.
-    async fn transfer_transaction(&self) -> anyhow::Result<(String, String, Vec<String>)> {
-        let addresses = self.onchain_cluster.wallet.get_addresses();
-
-        let recipient = addresses[1];
-        let tx = self
-            .onchain_cluster
-            .test_transaction_builder()
-            .await
-            .transfer_sui(Some(1_000), recipient)
-            .build();
-        let tx_digest = tx.digest().to_string();
-        let signed_tx = self.onchain_cluster.wallet.sign_transaction(&tx).await;
-        let (tx_bytes, sigs) = signed_tx.to_tx_bytes_and_signatures();
-        let tx_bytes = tx_bytes.encoded();
-        let sigs: Vec<_> = sigs.iter().map(|sig| sig.encoded()).collect();
-
-        Ok((tx_digest, tx_bytes, sigs))
-    }
-
-    /// Builds a transaction that would abort if called by a normal user.
-    async fn privileged_transaction(&self) -> anyhow::Result<(String, String, Vec<String>)> {
-        let tx: sui_types::transaction::TransactionData = self
-            .onchain_cluster
-            .test_transaction_builder()
-            .await
-            .call_request_remove_validator()
-            .build();
-        let tx_digest = tx.digest().to_string();
-        let signed_tx = self.onchain_cluster.wallet.sign_transaction(&tx).await;
-        let (tx_bytes, sigs) = signed_tx.to_tx_bytes_and_signatures();
-        let tx_bytes = tx_bytes.encoded();
-        let sigs: Vec<_> = sigs.iter().map(|sig| sig.encoded()).collect();
-
-        Ok((tx_digest, tx_bytes, sigs))
-    }
-
     async fn get_validator_address(&self) -> SuiAddress {
         self.onchain_cluster
             .grpc_client()
@@ -171,222 +133,6 @@ impl FnDelegationTestCluster {
     }
 }
 
-#[sim_test]
-async fn test_execution() {
-    telemetry_subscribers::init_for_testing();
-    let test_cluster = FnDelegationTestCluster::new()
-        .await
-        .expect("Failed to create test cluster");
-
-    let (tx_digest, tx_bytes, sigs) = test_cluster.transfer_transaction().await.unwrap();
-
-    // Call the executeTransactionBlock method and check that the response is valid.
-    let response = test_cluster
-        .execute_jsonrpc(
-            "sui_executeTransactionBlock".to_string(),
-            json!({
-                "tx_bytes": tx_bytes,
-                "signatures": sigs,
-                "options": {
-                    "showInput": true,
-                    "showRawInput": true,
-                    "showEffects": true,
-                    "showRawEffects": true,
-                    "showEvents": true,
-                    "showObjectChanges": true,
-                    "showBalanceChanges": true,
-                },
-            }),
-        )
-        .await
-        .unwrap();
-
-    tracing::info!("execution rpc response is {:?}", response);
-
-    // Checking that all the requested fields are present in the response.
-    assert_eq!(response["result"]["digest"], tx_digest);
-    assert!(response["result"]["transaction"].is_object());
-    assert!(response["result"]["rawTransaction"].is_string());
-    assert!(response["result"]["effects"].is_object());
-    assert!(response["result"]["rawEffects"].is_array());
-    assert!(response["result"]["events"].is_array());
-    assert!(response["result"]["objectChanges"].is_array());
-    assert!(response["result"]["balanceChanges"].is_array());
-}
-
-#[sim_test]
-async fn test_execution_with_deprecated_mode() {
-    telemetry_subscribers::init_for_testing();
-
-    let test_cluster = FnDelegationTestCluster::new()
-        .await
-        .expect("Failed to create test cluster");
-
-    let (_, tx_bytes, sigs) = test_cluster.transfer_transaction().await.unwrap();
-
-    // Call the executeTransactionBlock method and check that the response is valid.
-    let response = test_cluster
-        .execute_jsonrpc(
-            "sui_executeTransactionBlock".to_string(),
-            json!({
-                "tx_bytes": tx_bytes,
-                "signatures": sigs,
-                "request_type": "WaitForLocalExecution",
-            }),
-        )
-        .await
-        .unwrap();
-
-    tracing::info!("execution rpc response is {:?}", response);
-
-    assert_eq!(response["error"]["code"], -32602);
-    assert_eq!(
-        response["error"]["message"],
-        "Invalid Params: WaitForLocalExecution mode is deprecated"
-    );
-}
-
-#[sim_test]
-async fn test_execution_with_no_sigs() {
-    telemetry_subscribers::init_for_testing();
-
-    let test_cluster = FnDelegationTestCluster::new()
-        .await
-        .expect("Failed to create test cluster");
-
-    let (_, tx_bytes, _) = test_cluster.transfer_transaction().await.unwrap();
-
-    // Call the executeTransactionBlock method and check that the response is valid.
-    let response = test_cluster
-        .execute_jsonrpc(
-            "sui_executeTransactionBlock".to_string(),
-            json!({
-                "tx_bytes": tx_bytes,
-            }),
-        )
-        .await
-        .unwrap();
-
-    tracing::info!("execution rpc response is {:?}", response);
-
-    assert_eq!(response["error"]["code"], -32602);
-    assert_eq!(response["error"]["message"], "Invalid params");
-    assert!(
-        response["error"]["data"]
-            .as_str()
-            .unwrap()
-            .starts_with("missing field `signatures`")
-    );
-}
-
-#[sim_test]
-async fn test_execution_with_empty_sigs() {
-    telemetry_subscribers::init_for_testing();
-
-    let test_cluster = FnDelegationTestCluster::new()
-        .await
-        .expect("Failed to create test cluster");
-
-    let (_, tx_bytes, _) = test_cluster.transfer_transaction().await.unwrap();
-
-    // Call the executeTransactionBlock method and check that the response is valid.
-    let response = test_cluster
-        .execute_jsonrpc(
-            "sui_executeTransactionBlock".to_string(),
-            json!({
-                "tx_bytes": tx_bytes,
-                "signatures": [],
-            }),
-        )
-        .await
-        .unwrap();
-
-    tracing::info!("execution rpc response is {:?}", response);
-
-    assert_eq!(response["error"]["code"], -32002);
-    assert_eq!(
-        response["error"]["message"],
-        "Invalid user signature: Expect 1 signer signatures but got 0"
-    );
-}
-
-#[sim_test]
-async fn test_execution_with_aborted_tx() {
-    telemetry_subscribers::init_for_testing();
-
-    let test_cluster = FnDelegationTestCluster::new()
-        .await
-        .expect("Failed to create test cluster");
-
-    let (_, tx_bytes, sigs) = test_cluster.privileged_transaction().await.unwrap();
-
-    // Call the executeTransactionBlock method and check that the response is valid.
-    let response = test_cluster
-        .execute_jsonrpc(
-            "sui_executeTransactionBlock".to_string(),
-            json!({
-                "tx_bytes": tx_bytes,
-                "signatures": sigs,
-                "options": {
-                    "showEffects": true,
-                },
-            }),
-        )
-        .await
-        .unwrap();
-
-    tracing::info!("execution rpc response is {:?}", response);
-
-    assert_eq!(response["result"]["effects"]["status"]["status"], "failure");
-}
-
-#[sim_test]
-async fn test_dry_run() {
-    let test_cluster = FnDelegationTestCluster::new()
-        .await
-        .expect("Failed to create test cluster");
-
-    let (_, tx_bytes, _) = test_cluster.transfer_transaction().await.unwrap();
-
-    let response = test_cluster
-        .execute_jsonrpc(
-            "sui_dryRunTransactionBlock".to_string(),
-            json!({
-                "tx_bytes": tx_bytes,
-            }),
-        )
-        .await
-        .unwrap();
-
-    assert_eq!(response["result"]["effects"]["status"]["status"], "success");
-}
-
-#[sim_test]
-async fn test_dry_run_with_invalid_tx() {
-    let test_cluster = FnDelegationTestCluster::new()
-        .await
-        .expect("Failed to create test cluster");
-
-    let response = test_cluster
-        .execute_jsonrpc(
-            "sui_dryRunTransactionBlock".to_string(),
-            json!({
-                "tx_bytes": "invalid_tx_bytes",
-            }),
-        )
-        .await
-        .unwrap();
-
-    assert_eq!(response["error"]["code"], -32602);
-    assert_eq!(response["error"]["message"], "Invalid params");
-    assert!(
-        response["error"]["data"]
-            .as_str()
-            .unwrap()
-            .starts_with("Invalid value was given to the function")
-    );
-}
-
 #[sim_test]
 async fn test_get_stakes_and_by_ids() {
     let test_cluster = FnDelegationTestCluster::new()