fix: implement quilt patch methods for ClientMultiplexer (#2813)

* fix(daemon): implement quilt patch methods for ClientMultiplexer

The daemon's ClientMultiplexer was missing implementations for quilt
patch reading methods, causing "quilt functionality not supported by
this client" errors when calling quilt patch endpoints.

Add the following method implementations by delegating to the
underlying read_client:
- get_blobs_by_quilt_patch_ids
- get_patch_by_quilt_id_and_identifier
- list_patches_in_quilt

* chore: remove default impls from trait

---------

Co-authored-by: Will Bradley <[email protected]>

Author: liquid-helium

crates/walrus-service/src/client/daemon.rs

@@ -118,54 +118,21 @@ pub trait WalrusReadClient {
     fn get_blobs_by_quilt_patch_ids(
         &self,
         _quilt_patch_ids: &[QuiltPatchId],
-    ) -> impl std::future::Future<Output = ClientResult<Vec<QuiltStoreBlob<'static>>>> + Send {
-        async {
-            use walrus_sdk::error::ClientErrorKind;
-            Err(ClientError::from(ClientErrorKind::Other(
-                format!(
-                    "quilt functionality not supported by this client ({})",
-                    std::any::type_name::<Self>()
-                )
-                .into(),
-            )))
-        }
-    }
+    ) -> impl std::future::Future<Output = ClientResult<Vec<QuiltStoreBlob<'static>>>> + Send;
 
     /// Retrieves a blob from quilt by quilt ID and identifier.
     /// Default implementation returns an error indicating quilt is not supported.
     fn get_patch_by_quilt_id_and_identifier(
         &self,
         _quilt_id: &BlobId,
         _identifier: &str,
-    ) -> impl std::future::Future<Output = ClientResult<QuiltStoreBlob<'static>>> + Send {
-        async {
-            use walrus_sdk::error::ClientErrorKind;
-            Err(ClientError::from(ClientErrorKind::Other(
-                format!(
-                    "quilt functionality not supported by this client ({})",
-                    std::any::type_name::<Self>()
-                )
-                .into(),
-            )))
-        }
-    }
+    ) -> impl std::future::Future<Output = ClientResult<QuiltStoreBlob<'static>>> + Send;
 
     /// Lists patches in a quilt.
     fn list_patches_in_quilt(
         &self,
         _quilt_id: &BlobId,
-    ) -> impl std::future::Future<Output = ClientResult<Vec<QuiltPatchItem>>> + Send {
-        async {
-            use walrus_sdk::error::ClientErrorKind;
-            Err(ClientError::from(ClientErrorKind::Other(
-                format!(
-                    "quilt functionality not supported by this client ({})",
-                    std::any::type_name::<Self>()
-                )
-                .into(),
-            )))
-        }
-    }
+    ) -> impl std::future::Future<Output = ClientResult<Vec<QuiltPatchItem>>> + Send;
 }
 
 /// Trait representing a client that can write blobs to Walrus.
@@ -821,6 +788,28 @@ mod tests {
         ) -> ClientResult<ReadByteRangeResult> {
             unimplemented!("not needed for rate limit tests")
         }
+
+        async fn get_blobs_by_quilt_patch_ids(
+            &self,
+            _quilt_patch_ids: &[QuiltPatchId],
+        ) -> ClientResult<Vec<QuiltStoreBlob<'static>>> {
+            unimplemented!("not needed for rate limit tests")
+        }
+
+        async fn get_patch_by_quilt_id_and_identifier(
+            &self,
+            _quilt_id: &BlobId,
+            _identifier: &str,
+        ) -> ClientResult<QuiltStoreBlob<'static>> {
+            unimplemented!("not needed for rate limit tests")
+        }
+
+        async fn list_patches_in_quilt(
+            &self,
+            _quilt_id: &BlobId,
+        ) -> ClientResult<Vec<QuiltPatchItem>> {
+            unimplemented!("not needed for rate limit tests")
+        }
     }
 
     #[tokio::test]

crates/walrus-service/src/client/multiplexer.rs

@@ -17,6 +17,7 @@ use walrus_core::{
     BlobId,
     EncodingType,
     EpochCount,
+    QuiltPatchId,
     encoding::{
         ConsistencyCheckType,
         quilt_encoding::{QuiltStoreBlob, QuiltVersion},
@@ -51,7 +52,7 @@ use walrus_utils::metrics::Registry;
 
 use super::{
     cli::PublisherArgs,
-    daemon::{WalrusReadClient, WalrusWriteClient},
+    daemon::{QuiltPatchItem, WalrusReadClient, WalrusWriteClient},
     refill::{RefillHandles, Refiller},
 };
 use crate::client::refill::should_refill;
@@ -190,6 +191,29 @@ impl WalrusReadClient for ClientMultiplexer {
     ) -> ClientResult<BlobWithAttribute> {
         self.read_client.get_blob_by_object_id(blob_object_id).await
     }
+
+    async fn get_blobs_by_quilt_patch_ids(
+        &self,
+        quilt_patch_ids: &[QuiltPatchId],
+    ) -> ClientResult<Vec<QuiltStoreBlob<'static>>> {
+        self.read_client
+            .get_blobs_by_quilt_patch_ids(quilt_patch_ids)
+            .await
+    }
+
+    async fn get_patch_by_quilt_id_and_identifier(
+        &self,
+        quilt_id: &BlobId,
+        identifier: &str,
+    ) -> ClientResult<QuiltStoreBlob<'static>> {
+        self.read_client
+            .get_patch_by_quilt_id_and_identifier(quilt_id, identifier)
+            .await
+    }
+
+    async fn list_patches_in_quilt(&self, quilt_id: &BlobId) -> ClientResult<Vec<QuiltPatchItem>> {
+        self.read_client.list_patches_in_quilt(quilt_id).await
+    }
 }
 
 impl WalrusWriteClient for ClientMultiplexer {