fix node properties

Author: mutec

examples/sacn-scene-controller.json

@@ -12,7 +12,7 @@
         "type": "sacn_in",
         "z": "5b7a58776b1aebd9",
         "universe": 1,
-        "port": 5568,
+        "port": "",
         "interface": "",
         "mode": "htp",
         "output": "full",
@@ -30,7 +30,7 @@
         "type": "sacn_in",
         "z": "5b7a58776b1aebd9",
         "universe": "2",
-        "port": 5568,
+        "port": "",
         "interface": "",
         "mode": "ltp",
         "output": "full",
@@ -191,7 +191,7 @@
         "type": "sacn_out",
         "z": "5b7a58776b1aebd9",
         "universe": "3",
-        "port": 5568,
+        "port": "",
         "interface": "",
         "speed": "30",
         "priority": 100,
@@ -205,7 +205,7 @@
         "type": "sacn_out",
         "z": "5b7a58776b1aebd9",
         "universe": "4",
-        "port": 5568,
+        "port": "",
         "interface": "",
         "speed": "30",
         "priority": 100,

src/sacn/sacn-in.html

@@ -3,13 +3,6 @@
     <label for="node-input-name"><i class="fa fa-tag"></i> <span data-i18n="node-red:common.label.name"></span></label>
     <input type="text" id="node-input-name" data-i18n="[placeholder]node-red:common.label.name" style="width:70%;" />
   </div>
-  <div class="form-row">
-    <label for="node-input-property"
-      ><i class="fa fa-ellipsis-h"></i> <span data-i18n="node-red:common.label.property"></span
-    ></label>
-    <input type="text" id="node-input-property" style="width:70%;" />
-    <input type="hidden" id="node-input-outputs" />
-  </div>
 
   <div class="form-row">
     <label for="node-input-universe"
@@ -53,12 +46,14 @@
     category: "sACN",
     color: "#dcc515",
     defaults: {
+      name: {
+        value: "Scene-Controller",
+      },
       universe: {
         value: 1,
         required: true,
       },
       port: {
-        value: 5568,
         required: false,
       },
       interface: {
@@ -81,13 +76,13 @@
     outputs: 1,
     paletteLabel: "sACN in",
     icon: "bulb.png",
-    label: () => {
+    label: function () {
       return this.name || "sACN";
     },
-    labelStyle: () => {
+    labelStyle: function () {
       return this.name ? "node_label_italic" : "";
     },
-    oneditprepare: () => {
+    oneditprepare: function () {
       const outputCount = $("#node-input-outputs").val("{}");
       $("#node-input-universe").change(() => {
         const outputs = {};
@@ -97,13 +92,6 @@
         }
         outputCount.val(JSON.stringify(outputs));
       });
-      if (this.property === undefined) {
-        $("#node-input-property").val("payload");
-      }
-      $("#node-input-property").typedInput({
-        default: "msg",
-        types: ["msg"],
-      });
     },
   });
 </script>

src/sacn/sacn-in.js

@@ -3,12 +3,6 @@
     <label for="node-input-name"><i class="fa fa-tag"></i> <span data-i18n="node-red:common.label.name"></span></label>
     <input type="text" id="node-input-name" data-i18n="[placeholder]node-red:common.label.name" style="width:70%;" />
   </div>
-  <div class="form-row">
-    <label for="node-input-property"
-      ><i class="fa fa-ellipsis-h"></i> <span data-i18n="node-red:common.label.property"></span
-    ></label>
-    <input type="text" id="node-input-property" style="width:70%;" />
-  </div>
 
   <div class="form-row">
     <label for="node-input-universe"
@@ -62,12 +56,14 @@
     category: "sACN",
     color: "#dcc515",
     defaults: {
+      name: {
+        value: "Scene-Controller",
+      },
       universe: {
         value: 1,
         required: true,
       },
       port: {
-        value: 5568,
         required: false,
       },
       interface: {
@@ -91,20 +87,11 @@
     outputs: 0,
     paletteLabel: "sACN out",
     icon: "bulb.png",
-    label: () => {
+    label: function () {
       return this.name || "sACN";
     },
-    labelStyle: () => {
+    labelStyle: function () {
       return this.name ? "node_label_italic" : "";
     },
-    oneditprepare: () => {
-      if (this.property === undefined) {
-        $("#node-input-property").val("payload");
-      }
-      $("#node-input-property").typedInput({
-        default: "msg",
-        types: ["msg"],
-      });
-    },
   });
 </script>

src/sacn/sacn-in.js.map

@@ -16,15 +16,19 @@
   RED.nodes.registerType("scene_controller", {
     category: "sACN",
     color: "#dcc515",
-    defaults: {},
+    defaults: {
+      name: {
+        value: "Scene-Controller",
+      },
+    },
     inputs: 1,
     outputs: 1,
     paletteLabel: "Scene-Controller",
     icon: "bulb.png",
-    label: () => {
+    label: function () {
       return this.name || "Scene-Controller";
     },
-    labelStyle: () => {
+    labelStyle: function () {
       return this.name ? "node_label_italic" : "";
     },
   });

src/sacn/sacn-out.html

@@ -43,6 +43,8 @@ const nodeInit: NodeInitializer = (RED): void => {
     }
     if (config.port !== undefined && config.port > 0) {
       options.port = config.port;
+    } else {
+      options.port = 5568;
     }
 
     // internal functions

src/sacn/sacn-out.js

@@ -38,6 +38,8 @@ const nodeInit: NodeInitializer = (RED): void => {
     }
     if (config.port !== undefined && config.port > 0) {
       options.port = config.port;
+    } else {
+      options.port = 5568;
     }
 
     const sACN = new Sender(options);