fix: updates shouldn't block

fix: handle update errors better
fix: uniontentional app context style

Author: Tom Brewer

Mythetech.Framework.Desktop/Mythetech.Framework.Desktop.csproj

@@ -5,7 +5,7 @@
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <PackageId>Mythetech.Framework.Desktop</PackageId>
-        <Version>0.7.0</Version>
+        <Version>0.7.1</Version>
         <Authors>Mythetech</Authors>
         <Description>Desktop-specific components for cross platform blazor applications</Description>
         <PackageTags>blazor;desktop;photino;components;ui;framework;cross-platform</PackageTags>

Mythetech.Framework.Desktop/Updates/Events/UpdateEvents.cs

@@ -41,3 +41,16 @@ public record UpdateDownloadCompleted(UpdateInfo Update);
 /// </summary>
 /// <param name="Update">The update ready to install.</param>
 public record UpdateReadyToInstall(UpdateInfo Update);
+
+/// <summary>
+/// Published when an update check fails due to network or server errors.
+/// </summary>
+/// <param name="Error">The exception that occurred.</param>
+public record UpdateCheckFailed(Exception Error);
+
+/// <summary>
+/// Published when an update download fails.
+/// </summary>
+/// <param name="Update">The update that was being downloaded.</param>
+/// <param name="Error">The exception that occurred.</param>
+public record UpdateDownloadFailed(UpdateInfo Update, Exception Error);

Mythetech.Framework.Desktop/Updates/IUpdateService.cs

@@ -24,9 +24,16 @@ public interface IUpdateService
     /// <summary>
     /// Checks for available updates.
     /// Publishes UpdateCheckStarted, UpdateCheckCompleted, and UpdateAvailable events.
+    /// On failure, publishes UpdateCheckFailed.
     /// </summary>
     Task CheckForUpdatesAsync(CancellationToken cancellationToken = default);
 
+    /// <summary>
+    /// Checks for updates if the app is installed and AutoCheckOnStartup is enabled.
+    /// Call from your layout's OnAfterRenderAsync for non-blocking startup checks.
+    /// </summary>
+    Task CheckForUpdatesOnStartupAsync(CancellationToken cancellationToken = default);
+
     /// <summary>
     /// Downloads the available update.
     /// Publishes UpdateDownloadStarted, UpdateDownloadProgress, and UpdateDownloadCompleted events.

Mythetech.Framework.Desktop/Updates/UpdateRegistrationExtensions.cs

@@ -34,30 +34,14 @@ public static IServiceCollection AddUpdateService(this IServiceCollection servic
     }
 
     /// <summary>
-    /// Activates the update system by checking for updates on startup if enabled.
-    /// Call after UseMessageBus() and UseSettingsFramework().
+    /// Activates the update system. Call after UseMessageBus() and UseSettingsFramework().
+    /// To check for updates on startup, call <see cref="IUpdateService.CheckForUpdatesAsync"/>
+    /// from your layout's OnAfterRenderAsync method.
     /// </summary>
-    public static async Task<IServiceProvider> UseUpdateServiceAsync(this IServiceProvider serviceProvider)
+    public static IServiceProvider UseUpdateService(this IServiceProvider serviceProvider)
     {
-        var settingsProvider = serviceProvider.GetService<ISettingsProvider>();
-        var settings = settingsProvider?.GetSettings<UpdateSettings>();
-
-        if (settings?.AutoCheckOnStartup == true)
-        {
-            var updateService = serviceProvider.GetRequiredService<IUpdateService>();
-            if (updateService.IsInstalled)
-            {
-                try
-                {
-                    await updateService.CheckForUpdatesAsync();
-                }
-                catch
-                {
-                    // Silently ignore startup check failures
-                }
-            }
-        }
-
+        // Currently a no-op, but provides a consistent activation pattern
+        // and a place to add future initialization logic
         return serviceProvider;
     }
 }

Mythetech.Framework.Desktop/Updates/VelopackUpdateService.cs

@@ -2,6 +2,7 @@
 using Microsoft.Extensions.Options;
 using Mythetech.Framework.Desktop.Updates.Events;
 using Mythetech.Framework.Infrastructure.MessageBus;
+using Mythetech.Framework.Infrastructure.Settings;
 using Velopack;
 
 namespace Mythetech.Framework.Desktop.Updates;
@@ -14,17 +15,20 @@ public class VelopackUpdateService : IUpdateService
 {
     private readonly UpdateServiceOptions _options;
     private readonly IMessageBus _messageBus;
+    private readonly ISettingsProvider? _settingsProvider;
     private readonly ILogger<VelopackUpdateService> _logger;
     private UpdateManager? _updateManager;
 
     public VelopackUpdateService(
         IOptions<UpdateServiceOptions> options,
         IMessageBus messageBus,
-        ILogger<VelopackUpdateService> logger)
+        ILogger<VelopackUpdateService> logger,
+        ISettingsProvider? settingsProvider = null)
     {
         _options = options.Value;
         _messageBus = messageBus;
         _logger = logger;
+        _settingsProvider = settingsProvider;
     }
 
     /// <inheritdoc />
@@ -118,11 +122,30 @@ public async Task CheckForUpdatesAsync(CancellationToken cancellationToken = def
         catch (Exception ex)
         {
             _logger.LogError(ex, "Failed to check for updates");
+            await _messageBus.PublishAsync(new UpdateCheckFailed(ex));
             await _messageBus.PublishAsync(new UpdateCheckCompleted(null));
-            throw;
         }
     }
 
+    /// <inheritdoc />
+    public async Task CheckForUpdatesOnStartupAsync(CancellationToken cancellationToken = default)
+    {
+        if (!IsInstalled)
+        {
+            _logger.LogDebug("Startup update check skipped - app is not installed via Velopack");
+            return;
+        }
+
+        var settings = _settingsProvider?.GetSettings<UpdateSettings>();
+        if (settings?.AutoCheckOnStartup != true)
+        {
+            _logger.LogDebug("Startup update check skipped - disabled in settings");
+            return;
+        }
+
+        await CheckForUpdatesAsync(cancellationToken);
+    }
+
     /// <inheritdoc />
     public async Task DownloadUpdateAsync(CancellationToken cancellationToken = default)
     {
@@ -153,7 +176,7 @@ await manager.DownloadUpdatesAsync(veloUpdate, progress =>
         catch (Exception ex)
         {
             _logger.LogError(ex, "Failed to download update");
-            throw;
+            await _messageBus.PublishAsync(new UpdateDownloadFailed(AvailableUpdate, ex));
         }
     }
 

Mythetech.Framework/Components/AppContextDrawer/AppContextDrawer.razor.css

@@ -5,7 +5,6 @@
 
 .context-item-active {
     background-color: var(--mud-palette-secondary);
-    border-radius: 20%;
 }
 
 .context-panel-badge {

Mythetech.Framework/Components/AppContextDrawer/ContextPanelItem.razor.css

@@ -7,7 +7,7 @@
         <Company>Mythetech</Company>
         <GenerateDocumentationFile>True</GenerateDocumentationFile>
         <PackageId>Mythetech.Framework</PackageId>
-        <Version>0.7.0</Version>
+        <Version>0.7.1</Version>
         <Authors>Mythetech</Authors>
         <Description>Base component library for Mythetech applications</Description>
         <PackageTags>blazor;components;ui;framework;cross-platform;desktop;webassembly;photino</PackageTags>