Skip to content

Commit 3098b88

Browse files
committed
STYLE: Use DoubleToStringConverter::ToShortestString overload set
Simplified ITK's `FloatingPointNumberToString` implementation by using `DoubleToStringConverter::ToShortestString` overload set, proposed by pull request google/double-conversion#159 Related to issue google/double-conversion#160 "Add generic (template) methods for to_string (float or double)", opened by Florian Loitsch (floitsch).
1 parent 4ce3383 commit 3098b88

File tree

1 file changed

+1
-18
lines changed

1 file changed

+1
-18
lines changed

Modules/Core/Common/src/itkNumberToString.cxx

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,23 +23,6 @@
2323
namespace
2424
{
2525

26-
bool
27-
ConvertToShortest(const double_conversion::DoubleToStringConverter & converter,
28-
const double val,
29-
double_conversion::StringBuilder & builder)
30-
{
31-
return converter.ToShortest(val, &builder);
32-
}
33-
34-
bool
35-
ConvertToShortest(const double_conversion::DoubleToStringConverter & converter,
36-
const float val,
37-
double_conversion::StringBuilder & builder)
38-
{
39-
// Call the converter member function that is specific for single-precision `float`.
40-
return converter.ToShortestSingle(val, &builder);
41-
}
42-
4326
template <typename TValue>
4427
std::string
4528
FloatingPointNumberToString(const TValue val)
@@ -52,7 +35,7 @@ FloatingPointNumberToString(const TValue val)
5235

5336
double_conversion::StringBuilder builder(buf, sizeof(buf));
5437

55-
if (!ConvertToShortest(double_conversion::DoubleToStringConverter::EcmaScriptConverter(), val, builder))
38+
if (!double_conversion::DoubleToStringConverter::EcmaScriptConverter().ToShortestString(val, &builder))
5639
{
5740
itkGenericExceptionMacro(<< "Conversion failed for " << val);
5841
}

0 commit comments

Comments
 (0)