STYLE: Replace Fill calls with auto var = itk::MakeFilled<T> in tests

Replaced code of the form

    T var;
    var.Fill(x);

with `auto var = itk::MakeFilled<T>(x);`

Following C++ Core Guidelines, Oct 3, 2024, "Always initialize an object",
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-always

Using Notepad++, Replace in Files, doing:

    Find what: ^( [ ]+)([^ ].*)[ ]+(\w+);[\r\n]+\1\3\.Fill\(
    Replace with: $1auto $3 = itk::MakeFilled<$2>\(
    Filters: itk*Test*.cxx
    [v] Match case
    (*) Regular expression

Follow-up to
- pull request InsightSoftwareConsortium#4881
- pull request InsightSoftwareConsortium#4884
- pull request InsightSoftwareConsortium#4887

Author: N-Dekker

Modules/Core/Common/test/itkAdaptorComparisonTest.cxx

@@ -204,8 +204,7 @@ itkAdaptorComparisonTest(int, char *[])
   vector_image->SetRegions(region);
   vector_image->Allocate();
 
-  VectorImageType::PixelType initialVectorValue;
-  initialVectorValue.Fill(1.2345); // arbitrary value;
+  auto initialVectorValue = itk::MakeFilled<VectorImageType::PixelType>(1.2345); // arbitrary value;
   vector_image->FillBuffer(initialVectorValue);
 
   // Time trials

Modules/Core/Common/test/itkAggregateTypesGTest.cxx

@@ -287,11 +287,10 @@ class CommonIndexOffsetMathOps
 
     //============ Test Copy with Round/Cast Type ====================================
     {
-      AggregateType         known3s{ { 3, 3, 3, 3 } };
-      AggregateType         threes{};
-      AggregateType         known4s{ { 4, 4, 4, 4 } };
-      itk::Point<double, 4> p1;
-      p1.Fill(3.5);
+      AggregateType known3s{ { 3, 3, 3, 3 } };
+      AggregateType threes{};
+      AggregateType known4s{ { 4, 4, 4, 4 } };
+      auto          p1 = itk::MakeFilled<itk::Point<double, 4>>(3.5);
       threes.CopyWithRound(p1);
       ITK_EXPECT_VECTOR_NEAR(threes, known4s, 0);
 

Modules/Core/Common/test/itkConicShellInteriorExteriorSpatialFunctionTest.cxx

@@ -50,14 +50,12 @@ itkConicShellInteriorExteriorSpatialFunctionTest(int, char *[])
                                     InteriorExteriorSpatialFunction);
 
   // Set the conic shell properties
-  ConicShellInteriorExteriorSpatialFunctionType::InputType origin;
-  origin.Fill(1.0);
+  auto origin = itk::MakeFilled<ConicShellInteriorExteriorSpatialFunctionType::InputType>(1.0);
 
   conicShellInteriorExteriorSpatialFunction->SetOrigin(origin);
   ITK_TEST_SET_GET_VALUE(origin, conicShellInteriorExteriorSpatialFunction->GetOrigin());
 
-  ConicShellInteriorExteriorSpatialFunctionType::GradientType originGradient;
-  originGradient.Fill(1.6);
+  auto originGradient = itk::MakeFilled<ConicShellInteriorExteriorSpatialFunctionType::GradientType>(1.6);
   originGradient.GetVnlVector().normalize();
   conicShellInteriorExteriorSpatialFunction->SetOriginGradient(originGradient);
 

Modules/Core/Common/test/itkConstNeighborhoodIteratorTest.cxx

@@ -192,8 +192,7 @@ itkConstNeighborhoodIteratorTest(int, char *[])
   printnb<itk::ConstNeighborhoodIterator<TestImageType>>(ra_it, false);
 
   println("Adding [1, 1, 1, 1]");
-  OffsetType a_off;
-  a_off.Fill(1);
+  auto a_off = itk::MakeFilled<OffsetType>(1);
   ra_it += a_off;
   printnb<itk::ConstNeighborhoodIterator<TestImageType>>(ra_it, false);
 

Modules/Core/Common/test/itkConstNeighborhoodIteratorWithOnlyIndexTest.cxx

@@ -241,8 +241,7 @@ itkConstNeighborhoodIteratorWithOnlyIndexTestRun()
   ra_it.SetLocation(loc);
 
   std::cout << "Adding [1, 1, 1, 1]" << std::endl;
-  OffsetType a_off;
-  a_off.Fill(1);
+  auto a_off = itk::MakeFilled<OffsetType>(1);
   ra_it += a_off;
   for (unsigned int i = 0; i < 4; ++i)
   {

Modules/Core/Common/test/itkFrustumSpatialFunctionTest.cxx

@@ -43,8 +43,7 @@ itkFrustumSpatialFunctionTest(int, char *[])
   ITK_EXERCISE_BASIC_OBJECT_METHODS(frustrumSpatialFunction, FrustumSpatialFunction, InteriorExteriorSpatialFunction);
 
   // Set the frustum properties
-  FrustumSpatialFunctionType::InputType apex;
-  apex.Fill(1.1);
+  auto apex = itk::MakeFilled<FrustumSpatialFunctionType::InputType>(1.1);
 
   frustrumSpatialFunction->SetApex(apex);
   ITK_TEST_SET_GET_VALUE(apex, frustrumSpatialFunction->GetApex());

Modules/Core/Common/test/itkImageComputeOffsetAndIndexTest.cxx

@@ -62,8 +62,7 @@ ComputeOffset(TImage * image, unsigned int count, unsigned int repeat)
   typename TImage::OffsetValueType offset = 0;
   typename TImage::OffsetValueType accum = 0;
   typename TImage::IndexType       index;
-  typename TImage::OffsetType      indexIncr;
-  indexIncr.Fill(1);
+  auto                             indexIncr = itk::MakeFilled<typename TImage::OffsetType>(1);
 
   for (unsigned int j = 0; j < repeat; ++j)
   {
@@ -86,8 +85,7 @@ ComputeFastOffset(TImage * image, unsigned int count, unsigned int repeat)
   typename TImage::OffsetValueType offset = 0;
   typename TImage::OffsetValueType accum = 0;
   typename TImage::IndexType       index;
-  typename TImage::OffsetType      indexIncr;
-  indexIncr.Fill(1);
+  auto                             indexIncr = itk::MakeFilled<typename TImage::OffsetType>(1);
 
   const typename TImage::OffsetValueType * offsetTable = image->GetOffsetTable();
 

Modules/Core/Common/test/itkImageIteratorTest.cxx

@@ -68,8 +68,7 @@ itkImageIteratorTest(int, char *[])
   o3->SetSpacing(spacing3D);
 
   o3->Allocate();
-  itk::Vector<unsigned short, 5> fillValue;
-  fillValue.Fill(itk::NumericTraits<unsigned short>::max());
+  auto fillValue = itk::MakeFilled<itk::Vector<unsigned short, 5>>(itk::NumericTraits<unsigned short>::max());
   o3->FillBuffer(fillValue);
 
   std::cout << "Setting/Getting a pixel" << std::endl;

Modules/Core/Common/test/itkImageIteratorWithIndexTest.cxx

@@ -264,8 +264,7 @@ itkImageIteratorWithIndexTest(int, char *[])
 
   std::cout << "Testing with Image< itk::Vector<char,4>, 3 > " << std::endl;
   using VC = itk::Vector<char, 4>;
-  VC vc;
-  vc.Fill(127);
+  auto                                            vc = itk::MakeFilled<VC>(127);
   itkImageIteratorWithIndexTestIteratorTester<VC> TesterVC(vc);
   if (TesterVC.TestIterator() == false)
   {
@@ -282,8 +281,7 @@ itkImageIteratorWithIndexTest(int, char *[])
 
   std::cout << "Testing with Image< itk::Vector<unsigned char,4>, 3 > " << std::endl;
   using VUC = itk::Vector<unsigned char, 4>;
-  VUC vuc;
-  vuc.Fill(10);
+  auto                                             vuc = itk::MakeFilled<VUC>(10);
   itkImageIteratorWithIndexTestIteratorTester<VUC> TesterVUC(vuc);
   if (TesterVUC.TestIterator() == false)
   {
@@ -300,8 +298,7 @@ itkImageIteratorWithIndexTest(int, char *[])
 
   std::cout << "Testing with Image< itk::Vector<short,4>, 3 > " << std::endl;
   using VS = itk::Vector<short, 4>;
-  VS vs;
-  vs.Fill(10);
+  auto                                            vs = itk::MakeFilled<VS>(10);
   itkImageIteratorWithIndexTestIteratorTester<VS> TesterVS(vs);
   if (TesterVS.TestIterator() == false)
   {
@@ -318,8 +315,7 @@ itkImageIteratorWithIndexTest(int, char *[])
 
   std::cout << "Testing with Image< itk::Vector<unsigned short,4>, 3 > " << std::endl;
   using VUS = itk::Vector<unsigned short, 4>;
-  VUS vus;
-  vus.Fill(10);
+  auto                                             vus = itk::MakeFilled<VUS>(10);
   itkImageIteratorWithIndexTestIteratorTester<VUS> TesterVUS(vus);
   if (TesterVUS.TestIterator() == false)
   {
@@ -336,8 +332,7 @@ itkImageIteratorWithIndexTest(int, char *[])
 
   std::cout << "Testing with Image< itk::Vector<int,4>, 3 > " << std::endl;
   using VI = itk::Vector<int, 4>;
-  VI vi;
-  vi.Fill(10);
+  auto                                            vi = itk::MakeFilled<VI>(10);
   itkImageIteratorWithIndexTestIteratorTester<VI> TesterVI(vi);
   if (TesterVI.TestIterator() == false)
   {
@@ -354,8 +349,7 @@ itkImageIteratorWithIndexTest(int, char *[])
 
   std::cout << "Testing with Image< itk::Vector<unsigned int,4>, 3 > " << std::endl;
   using VUI = itk::Vector<unsigned int, 4>;
-  VUI vui;
-  vui.Fill(10);
+  auto                                             vui = itk::MakeFilled<VUI>(10);
   itkImageIteratorWithIndexTestIteratorTester<VUI> TesterVUI(vui);
   if (TesterVUI.TestIterator() == false)
   {
@@ -372,8 +366,7 @@ itkImageIteratorWithIndexTest(int, char *[])
 
   std::cout << "Testing with Image< itk::Vector<float,4>, 3 > " << std::endl;
   using VF = itk::Vector<float, 4>;
-  VF vf;
-  vf.Fill(10);
+  auto                                            vf = itk::MakeFilled<VF>(10);
   itkImageIteratorWithIndexTestIteratorTester<VF> TesterVF(vf);
   if (TesterVF.TestIterator() == false)
   {
@@ -390,8 +383,7 @@ itkImageIteratorWithIndexTest(int, char *[])
 
   std::cout << "Testing with Image< itk::Vector<double,4>, 3 > " << std::endl;
   using VD = itk::Vector<double, 4>;
-  VD vd;
-  vd.Fill(10);
+  auto                                            vd = itk::MakeFilled<VD>(10);
   itkImageIteratorWithIndexTestIteratorTester<VD> TesterVD(vd);
   if (TesterVD.TestIterator() == false)
   {

Modules/Core/Common/test/itkImageTest.cxx

@@ -62,10 +62,8 @@ itkImageTest(int, char *[])
   image->GetSource();
   image->DisconnectPipeline();
 
-  Image::SpacingType spacing;
-  spacing.Fill(1.0);
-  Image::PointType origin;
-  origin.Fill(1.0);
+  auto                 spacing = itk::MakeFilled<Image::SpacingType>(1.0);
+  auto                 origin = itk::MakeFilled<Image::PointType>(1.0);
   Image::DirectionType direction;
   direction[0][0] = .5;
   direction[0][1] = .7;
@@ -127,9 +125,8 @@ itkImageTest(int, char *[])
   region.SetSize(size);
   image->SetRegions(region);
 
-  auto               imageRef = Image::New();
-  Image::SpacingType spacingRef;
-  spacingRef.Fill(2);
+  auto                 imageRef = Image::New();
+  auto                 spacingRef = itk::MakeFilled<Image::SpacingType>(2);
   Image::PointType     originRef{};
   Image::DirectionType directionRef;
   directionRef.SetIdentity();
@@ -161,9 +158,8 @@ itkImageTest(int, char *[])
   }
 
   using Image3D = itk::Image<float, 3>;
-  auto                 volume = Image3D::New();
-  Image3D::SpacingType spacingVol;
-  spacingVol.Fill(1);
+  auto                   volume = Image3D::New();
+  auto                   spacingVol = itk::MakeFilled<Image3D::SpacingType>(1);
   Image3D::PointType     originVol{};
   Image3D::DirectionType directionVol;
   directionVol.SetIdentity();