feat: replace composite primary keys in pivot tables with a single 'id' column and remove original PK

Author: N3XT0R

src/Service/Generator/Compiler/Mapper/PrimaryKeyMapper.php

@@ -22,10 +22,13 @@ public function generatePrimary(PrimaryKeyEntity $index): string
     {
         $columns = $index->getColumns();
         $columnList = "['" . implode("', '", $columns) . "']";
-        $name = "'" . $index->getName() . "'";
+
+        $methodCall = !empty($index->getName())
+            ? "primary($columnList, '" . $index->getName() . "')"
+            : "primary($columnList)";
 
         return $this->chainMethodsToString([
-            "primary($columnList, $name)"
+            $methodCall
         ]);
     }
 }

src/Service/Generator/Normalization/Processors/PivotProcessor.php

@@ -2,6 +2,8 @@
 
 namespace N3XT0R\MigrationGenerator\Service\Generator\Normalization\Processors;
 
+use N3XT0R\MigrationGenerator\Service\Generator\Definition\Entity\FieldEntity;
+use N3XT0R\MigrationGenerator\Service\Generator\Definition\Entity\PrimaryKeyEntity;
 use N3XT0R\MigrationGenerator\Service\Generator\Definition\Entity\ResultEntity;
 use N3XT0R\MigrationGenerator\Service\Generator\Normalization\Context\NormalizationContext;
 
@@ -12,42 +14,27 @@ public function process(NormalizationContext $context): ResultEntity
         $result = $context->getCurrent();
         $results = $result->getResults();
 
-        foreach ($results as $tableName => $definition) {
-            $primary = $definition['primary'] ?? [];
-
-            if (is_array($primary) && count($primary) > 1) {
-                $definition['columns'] = [
-                        'id' => [
-                            'type' => 'int',
-                            'primary' => true,
-                            'autoIncrement' => true,
-                        ]
-                    ] + $definition['columns'];
-
-                foreach ($primary as $column) {
-                    if (isset($definition['columns'][$column])) {
-                        unset($definition['columns'][$column]['primary']);
-                        $definition['columns'][$column]['foreign'] = $this->guessForeignTarget($column);
-                    }
-                }
-
-                // 3. Neue primary definition
-                $definition['primary'] = ['id'];
-
-                $results[$tableName] = $definition;
-                dd($results);
-                $result->setResults($results);
+        foreach ($results as $tableName => $definitions) {
+            $primary = current($definitions['primaryKey']);
+            if ($primary instanceof PrimaryKeyEntity && count($primary->getColumns()) >= 2) {
+                $idField = new FieldEntity();
+                $idField->setTable($tableName);
+                $idField->setType('bigInteger');
+                $idField->setArguments(['autoIncrement' => true]);
+                $idField->setOptions([
+                    'default' => null,
+                    'unsigned' => true,
+                    'nullable' => false
+                ]);
+
+                $idField->setColumnName('id');
+                $results[$tableName]['table'] = ['id' => $idField, ...$definitions['table']];
+                unset($results[$tableName]['primaryKey']);
             }
         }
 
+        $result->setResults($results);
         $context->update($result);
         return $result;
     }
-
-    private function guessForeignTarget(string $column): string
-    {
-        // z. B. user_id → users.id
-        $name = rtrim($column, '_id') . 's';
-        return "$name.id";
-    }
 }

src/Service/Generator/Normalization/SchemaNormalizationManager.php

@@ -42,6 +42,7 @@ public function addProcessor(ProcessorInterface $processor): void
 
     /**
      * Returns all registered processors.
+     * @return ProcessorInterface[]|iterable
      */
     public function getProcessors(): iterable
     {