Skip to content

TilesRenderer: Change "cached" to "engineData" #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gkjohnson merged 6 commits into from
Jan 17, 2026
Merged

TilesRenderer: Change "cached" to "engineData" #1429

gkjohnson merged 6 commits into from
Jan 17, 2026
+107 −96

Conversation

@gkjohnson
Copy link
Contributor

@gkjohnson gkjohnson commented Dec 31, 2025 •
edited
Loading

Related to #1375

  • Change "cached" to "engineData"
  • Define the "engineData" object in "TilesRendererBase" for reusability

Future PR TODO

  • Adjust naming of "scene" to a more common field name with backwards compatibility (possibly "model" and "modelMetadata")
  • Move traversal fields to a "traversal" field

@gkjohnson gkjohnson mentioned this pull request Jan 3, 2026
Open
@gkjohnson
Copy link
Contributor Author

gkjohnson commented Jan 13, 2026

cc @dbuck - Similar to #1421, the internal "tile.cached" field is changing, which I know you'd discussed using in the past. #1431 will also be reorganizing some other internal tile fields on tile, as well.

@gkjohnson gkjohnson merged commit 31c65bb into master Jan 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gkjohnson