add promotion tests for overlapping title patterns and title changes

Author: CarsonDavis

sde_collections/tests/test_promote_collection.py

@@ -1,10 +1,10 @@
 # docker-compose -f local.yml run --rm django pytest sde_collections/tests/test_promote_collection.py
-
 import pytest
 
 from sde_collections.models.delta_patterns import (
     DeltaExcludePattern,
     DeltaIncludePattern,
+    DeltaTitlePattern,
 )
 from sde_collections.models.delta_url import CuratedUrl, DeltaUrl
 from sde_collections.tests.factories import CollectionFactory
@@ -116,3 +116,95 @@ def test_patterns_reapplied_after_promotion(collection):
 
     # Verify exclusion status
     assert curated_urls.filter(url="https://exclude.com", excluded=True).exists()
+
+
+@pytest.mark.django_db
+def test_promotion_with_overlapping_patterns_and_deletion():
+    """Test complex scenario with multiple overlapping patterns and URL deletion."""
+    collection = CollectionFactory()
+
+    # Create a more complex set of URLs that might trigger overlapping patterns
+    urls = [
+        "https://example.com/docs/guide1",
+        "https://example.com/docs/guide2",
+        "https://example.com/api/v1/doc1",
+        "https://example.com/api/v1/doc2",
+    ]
+
+    # Create initial DeltaUrls
+    for url in urls:
+        DeltaUrl.objects.create(collection=collection, url=url, scraped_title=f"Title for {url}")
+
+    # Create overlapping patterns that will affect the same URLs
+    patterns = [
+        {"pattern": ".*docs.*", "title": "Documentation: {title}"},
+        {"pattern": ".*guide.*", "title": "Guide: {title}"},
+        {"pattern": ".*api.*", "title": "API: {title}"},
+        {"pattern": ".*doc[0-9]", "title": "Doc Number: {title}"},
+    ]
+
+    # Create and apply multiple patterns
+    title_patterns = []
+    for p in patterns:
+        pattern = DeltaTitlePattern.objects.create(
+            collection=collection,
+            match_pattern=p["pattern"],
+            match_pattern_type=2,  # Multi-URL Pattern
+            title_pattern=p["title"],
+        )
+        pattern.apply()
+        title_patterns.append(pattern)
+
+    # Initial promotion
+    collection.promote_to_curated()
+
+    # Verify our complex setup
+    for pattern in title_patterns:
+        matching_urls = pattern.curated_urls.all()
+        print(f"\nPattern '{pattern.match_pattern}' matches {matching_urls.count()} URLs:")
+        for url in matching_urls:
+            print(f"- {url.url}")
+
+    # Now create deletion DeltaUrls but with overlapping pattern matches
+    urls_to_delete = ["https://example.com/docs/guide1", "https://example.com/api/v1/doc1"]
+    for url in urls_to_delete:
+        DeltaUrl.objects.create(collection=collection, url=url, to_delete=True)
+
+    # Try the promotion - this should trigger similar conditions to production
+    collection.promote_to_curated()
+
+    # Print final state for debugging
+    print("\nFinal state:")
+    for pattern in title_patterns:
+        print(f"\nPattern '{pattern.match_pattern}':")
+        for url in pattern.curated_urls.all():
+            print(f"- {url.url}")
+
+
+@pytest.mark.django_db
+def test_promotion_with_title_change():
+    """Test updating a CuratedUrl that has active title pattern relationships."""
+    collection = CollectionFactory()
+
+    # Create initial DeltaUrl and promote it
+    url = "https://example.com/doc1"
+    DeltaUrl.objects.create(collection=collection, url=url, scraped_title="Original Title")
+
+    # Create and apply a title pattern
+    pattern = DeltaTitlePattern.objects.create(
+        collection=collection, match_pattern=".*doc1", match_pattern_type=2, title_pattern="Pattern: {title}"
+    )
+    pattern.apply()
+
+    # Initial promotion
+    collection.promote_to_curated()
+
+    # Verify pattern relationship exists
+    curated = CuratedUrl.objects.get(url=url)
+    assert pattern.curated_urls.filter(id=curated.id).exists()
+
+    # Now create new DeltaUrl with updated title
+    DeltaUrl.objects.create(collection=collection, url=url, scraped_title="New Title")  # Changed title
+
+    # This should trigger the same error we're seeing in production
+    collection.promote_to_curated()