Skip to content

Commit 1d4ba0c

Browse files
authored
Merge branch 'dev' into 1014-add-logs-when-importing-urls-so-we-know-how-many-were-expected-how-many-succeeded-and-how-many-failed
2 parents 2f72222 + c77892a commit 1d4ba0c

File tree

3 files changed

+31
-0
lines changed

3 files changed

+31
-0
lines changed

.github/workflows/run_full_test_suite.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ on:
44
pull_request:
55
branches:
66
- dev
7+
paths-ignore:
8+
- '**/*.md'
79

810
jobs:
911
run-tests:

CHANGELOG.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,26 @@ For each PR made, an entry should be added to this changelog. It should contain
5151
- In `title_patterns_table` definition, corrected the column reference
5252
- Made `match_pattern_type` searchable
5353
- Corrected the column references and made code consistent on all the other tables, i.e., `exclude_patterns_table`, `include_patterns_table`, `division_patterns_table` and `document_type_patterns_table`
54+
55+
- 1001-tests-for-critical-functionalities
56+
- Description: Critical functionalities have been identified and listed, and critical areas lacking tests listed
57+
- Changes:
58+
- Integrated coverage.py as an indicative tool in the workflow for automated coverage reports on PRs, with separate display from test results.
59+
- Introduced docs/architecture-decisions/testing_strategy.md, which includes the coverage report, lists critical areas, and specifically identifies those critical areas that are untested or under-tested.
60+
61+
- 1192-finalize-the-infrastructure-for-frontend-testing
62+
- Description: Set up comprehensive frontend testing infrastructure using Selenium WebDriver with Chrome, establishing a foundation for automated UI testing.
63+
- Changes:
64+
- Added Selenium testing dependency to `requirements/local.txt`
65+
- Updated Dockerfile to support Chrome and ChromeDriver
66+
- Created BaseTestCase and AuthenticationMixin for reusable test components
67+
- Implemented core authentication test suite
68+
69+
- 1195-implement-unit-test-for-forms-on-the-frontend
70+
- Description: Implemented comprehensive frontend test suite covering authentication, collection management, search functionality, and pattern application forms.
71+
- Changes:
72+
- Added tests for authentication flows
73+
- Implemented collection display and data table tests
74+
- Added universal search functionality tests
75+
- Created search pane filter tests
76+
- Added pattern application form tests with validation checks

sde_collections/tests/frontend/test_pattern_application.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,12 @@ def test_create_title_pattern(self):
141141
assert "3" in row_text
142142

143143
self.driver.get(f"{self.live_server_url}/{self.collection.id}/delta-urls")
144+
145+
# Wait for at least one row to be present in the table
146+
self.wait.until(
147+
EC.presence_of_element_located((By.CSS_SELECTOR, "#delta_urls_table tbody tr td:not(.dt-empty)"))
148+
)
149+
144150
table_html = self.driver.find_element(By.ID, "delta_urls_table").get_attribute("outerHTML")
145151

146152
# Verify that previous curated_url now appear in delta_urls page after pattern application

0 commit comments

Comments
 (0)