Skip to content

Commit 48c66b8

Browse files
committed
improve logic in get_backup_filename
1 parent e59366a commit 48c66b8

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

sde_collections/management/commands/database_backup.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,17 @@ def add_arguments(self, parser):
5656
)
5757

5858
def get_backup_filename(self, server: Server, compress: bool) -> tuple[str, str]:
59-
"""Generate backup filename and actual dump path."""
59+
"""Generate backup filename and actual dump path.
60+
61+
Returns:
62+
tuple[str, str]: A tuple containing (final_filename, temp_filename)
63+
- final_filename: The name of the final backup file (with .gz if compressed)
64+
- temp_filename: The name of the temporary dump file (always without .gz)
65+
"""
6066
date_str = datetime.now().strftime("%Y%m%d")
61-
base_name = f"{server.value.lower()}_backup_{date_str}.sql"
62-
return f"{base_name}.gz" if compress else base_name, base_name
67+
temp_filename = f"{server.value.lower()}_backup_{date_str}.sql"
68+
final_filename = f"{temp_filename}.gz" if compress else temp_filename
69+
return final_filename, temp_filename
6370

6471
def run_pg_dump(self, output_file: str, env: dict) -> None:
6572
"""Execute pg_dump with given parameters."""

0 commit comments

Comments
 (0)