Merge pull request #1228 from NASA-IMPACT/3228-bugfix-preserve-scroll-position--document-type-selection-behavior-on-individual-urls

changes js code to preserve y scroll position while saving

Author: dhanur-sharma

CHANGELOG.md

@@ -46,6 +46,12 @@ For each PR made, an entry should be added to this changelog. It should contain
     - Used regex to catch any HTML content comming in as an input to form fields
     - Called this class within the serializer for necessary fields
 
+- 3228-bugfix-preserve-scroll-position--document-type-selection-behavior-on-individual-urls
+  - Description: Upon selecting a document type on any individual URL, the page refreshes and returns to the top. This is not necessarily a bug but an inconvenience, especially when working at the bottom of the page. Fix the JS code.
+  - Changes:
+    - Added a constant `scrollPosition` within `postDocumentTypePatterns` to store the y coordinate postion on the page
+    - Modified the ajax relaod to navigate to this position upon posting/saving the document type changes.
+
 - 3227-bugfix-title-patterns-selecting-multi-url-pattern-does-nothing
   - Description: When selecting options from the match pattern type filter, the system does not filter the results as expected. Instead of displaying only the chosen variety of patterns, it continues to show all patterns.
   - Changes:

sde_indexing_helper/static/js/delta_url_list.js

@@ -1400,7 +1400,8 @@ function handleHideorShowSubmitButton() {
 }
 
 function handleDocumentTypeSelect() {
-  $("body").on("click", ".document_type_select", function () {
+  $("body").on("click", ".document_type_select", function (e) {
+    e.preventDefault();
     $match_pattern = $(this)
       .parents(".document_type_dropdown")
       .data("match-pattern");
@@ -1581,6 +1582,8 @@ function postDocumentTypePatterns(
     return;
   }
 
+  const scrollPosition = window.scrollY;
+
   $.ajax({
     url: "/api/document-type-patterns/",
     type: "POST",
@@ -1592,7 +1595,9 @@ function postDocumentTypePatterns(
       csrfmiddlewaretoken: csrftoken,
     },
     success: function (data) {
-      $("#delta_urls_table").DataTable().ajax.reload(null, false);
+      $("#delta_urls_table").DataTable().ajax.reload(function() {
+        window.scrollTo(0, scrollPosition);
+      }, false);
       $("#document_type_patterns_table").DataTable().ajax.reload(null, false);
       if (currentTab === "") { //Only add a notification if we are on the first tab
         newDocumentTypePatternsCount = newDocumentTypePatternsCount + 1;