Skip to content

Commit 6ea0df5

Browse files
make sure the affected urls on title patterns are updated correctly
1 parent d894b51 commit 6ea0df5

File tree

1 file changed

+4
-18
lines changed

1 file changed

+4
-18
lines changed

sde_collections/models/pattern.py

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,9 @@
22

33
from django.apps import apps
44
from django.core.exceptions import ValidationError
5-
from django.db import models, transaction
6-
from django.db.models.signals import post_save
7-
from django.dispatch import receiver
8-
9-
from sde_collections.tasks import resolve_title_pattern
10-
11-
from ..utils.title_resolver import (
12-
is_valid_fstring,
13-
is_valid_xpath,
14-
parse_title,
15-
resolve_title,
16-
)
5+
from django.db import models
6+
7+
from ..utils.title_resolver import is_valid_fstring, is_valid_xpath, parse_title
178
from .collection_choice_fields import DocumentTypes
189

1910

@@ -170,12 +161,6 @@ def apply(self) -> None:
170161
ResolvedTitleError = apps.get_model("sde_collections", "ResolvedTitleError")
171162

172163
for candidate_url in matched_urls:
173-
context = {
174-
"url": candidate_url.url,
175-
"title": candidate_url.scraped_title,
176-
"collection": self.collection.name,
177-
}
178-
179164
try:
180165
# generated_title = resolve_title(self.title_pattern, context)
181166
generated_title = self.title_pattern
@@ -190,6 +175,7 @@ def apply(self) -> None:
190175

191176
candidate_url.generated_title = generated_title
192177
candidate_url.save()
178+
updated_urls.append(candidate_url)
193179

194180
except (ValueError, ValidationError) as e:
195181
message = str(e)

0 commit comments

Comments
 (0)